Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add vs_build dep to windows performance test #99602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Mar 6, 2022
Merged

Add vs_build dep to windows performance test #99602

fluttergithubbot merged 3 commits into from
Mar 6, 2022

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 5, 2022

This test is failing on ToT because there is no visual studio installed. Maybe an explicit property is required?

@jonahwilliams jonahwilliams requested a review from dnfield March 5, 2022 16:41
dnfield
dnfield approved these changes Mar 5, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rslgtm

CaseyHillers
CaseyHillers reviewed Mar 6, 2022
View reviewed changes
.ci.yaml
properties:
tags: >
["devicelab","hostonly"]
dependencies: >-
Copy link
Contributor

@CaseyHillers CaseyHillers Mar 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove bringup: true to run it in presubmit to see if this fixes it before landing

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! that worked great :D

@jonahwilliams jonahwilliams changed the title Try adding vs_build dep to windows performance test [DO NOT SUBMIT] Try adding vs_build dep to windows performance test Mar 6, 2022
@jonahwilliams jonahwilliams changed the title [DO NOT SUBMIT] Try adding vs_build dep to windows performance test Add vs_build dep to windows performance test Mar 6, 2022
@fluttergithubbot fluttergithubbot merged commit 070c494 into flutter:master Mar 6, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
7622aa6 
…#99602)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
f1bdf4b 
…#99602)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
95bd629 
…#99602)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
c4dcb19 
…#99602)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
f828226 
…#99602)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
5c50369 
…#99602)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
c6514d9 
…#99602)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
20f838b 
…#99602)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
c7d09bf 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
2de9a72 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
f033d83 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
341faf3 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
7c1206e 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
1c8caf0 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
dfbd685 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
815b445 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
9b14bed 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
1852d81 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
5d082de 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
bf524dd 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
a91ff7b 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
a7fca35 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
a224332 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
dac267e 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
c000f27 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
a4ad2df 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
ebc4d28 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
b9c649b 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
094b69a 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
00fd748 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
524f93d 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
f8e83ee 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
1b7b806 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
ae78135 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
ea006d0 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
7de9046 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
989387b 
…#99602)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
070c494 Add vs_build dep to windows performance test (flutter/flutter…
30421c3 
…#99602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keyonghan keyonghan Awaiting requested review from keyonghan

2 more reviewers

@CaseyHillers CaseyHillers CaseyHillers left review comments

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @CaseyHillers @dnfield @fluttergithubbot