Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix ColorScheme.shadow to default to black even for dark themes. #99722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2022
Merged

Fix ColorScheme.shadow to default to black even for dark themes. #99722

merged 1 commit into from
Mar 9, 2022

Conversation

darrenaustin
Copy link
Contributor

Fixes: #98455

As @rydmike rightly pointed out the current default for ColorScheme.shadow shouldn't be onBackground as it leads to white shadows in the default dark themes.

This PR changes the default value for shadow to black (const Color(0xff000000)) as intended.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 7, 2022
guidezpl
guidezpl approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@darrenaustin darrenaustin merged commit e8af40f into flutter:master Mar 9, 2022
@darrenaustin darrenaustin deleted the shadow_color_default branch March 9, 2022 20:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
68a1842 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
fb13cdb 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
6a7a6a8 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
ecdb983 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
26ccd0d 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
697380d 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
13bc9a4 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
1ce8046 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
19d14f5 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
5e7a10a 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
7d3c0ba 
…emes. (flutter/flutter#99722)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
7c85efe 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
49f3d07 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
7a5ec99 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
50b3adc 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
826c335 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
ed32e63 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
a813ad6 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
620152d 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
968ee9c 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
ebb52b0 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
59b364d 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
732cfbe 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
0b8f0ef 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
161cc19 
…emes. (flutter/flutter#99722)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
e8af40f Fix ColorScheme.shadow to default to black even for dark th…
296d172 
…emes. (flutter/flutter#99722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ColorScheme.shadow defaults to onBackground in both light and dark brightness in ColorScheme
2 participants
@darrenaustin @guidezpl