Fix to pass additional args from the Flutter test template (#7261)#8836
Open
dkandalov wants to merge 1 commit intoflutter:mainfrom
Open
Fix to pass additional args from the Flutter test template (#7261)#8836dkandalov wants to merge 1 commit intoflutter:mainfrom
dkandalov wants to merge 1 commit intoflutter:mainfrom
Conversation
1 task
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where additional arguments from a test run configuration template were not being preserved. The change involves explicitly copying the additionalArgs from the existing configuration to the newly created TestFields. While the fix is correct, there is some code duplication across the setupForSingleTest, setupForDartFile, and setupForDirectory methods. I've left a comment with a suggestion to refactor this for better maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to pass additional args from the Flutter test template (#7261)
Contribution guidelines:
dart format.