Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[pigeon] Tidy imports and "ignore" comments#11149

Open
srawlins wants to merge 4 commits intoflutter:mainfrom
srawlins:imports
Open

[pigeon] Tidy imports and "ignore" comments#11149
srawlins wants to merge 4 commits intoflutter:mainfrom
srawlins:imports

Conversation

@srawlins
Copy link
Contributor

@srawlins srawlins commented Mar 1, 2026

  • Uint8List appears to be no longer needed.
  • The only reason foundation.dart was imported was for the annotations exported by the meta package.
  • Instead of ignoring individual lint rules, all lint rules should be ignored, so that the generated code doesn't fail users' CI, when the code is out of their control.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@srawlins srawlins requested a review from tarrinneal as a code owner March 1, 2026 18:21
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 1, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dart code generator for Pigeon. The changes include:

  • Modifying the generated ignore_for_file comments to use type=lint, which disables all lint rules for the generated files.
  • Removing the import of Uint8List from dart:typed_data in generated files.
  • Changing the source of annotations (e.g., @immutable) from the Flutter foundation library to the meta package.
    These generator changes are reflected in the updated example and test files. The package version in pubspec.yaml, CHANGELOG.md, and generator_tools.dart has been updated to 26.1.10.

@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Mar 2, 2026 •
edited
Loading

  • Instead of ignoring individual lint rules, all lint rules should be ignored, so that the generated code doesn't fail users' CI, when the code is out of their control.

We should make this something we can override internally for our own test generation; while we don't want to fail client analysis, we also don't want to introduce actual problems that lints would catch without our CI telling us. (E.g., if we leave out an await where we should have one, we absolutely want our CI to fail.)

@srawlins
Copy link
Contributor Author

srawlins commented Mar 2, 2026

That's a great idea! Is there one (or a few) cental spot where I could put a flag, for code generation "for/during tests"? Are there already tests that assert that new code doesn't have warnings or lints? Or is that mainly the checked-in code-generated files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

p: pigeon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srawlins @stuartmorgan-g