Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[cross_file] Remove unneeded flutter dependency.#1712

Merged
fluttergithubbot merged 3 commits intoflutter:mainfrom
tomassasovsky:cross-file-remove-flutter-dep
May 4, 2022
Merged

[cross_file] Remove unneeded flutter dependency.#1712
fluttergithubbot merged 3 commits intoflutter:mainfrom
tomassasovsky:cross-file-remove-flutter-dep

Conversation

@tomassasovsky
Copy link
Contributor

@tomassasovsky tomassasovsky commented May 2, 2022 •
edited by ditman
Loading

Removed unused Flutter dependencies to the cross_file package. Can now be imported and used from other Dart packages without the need of making it a Flutter package.

From #1664
Fixes flutter/flutter#102934

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@tomassasovsky tomassasovsky mentioned this pull request May 2, 2022
Closed
11 tasks
@ditman ditman self-requested a review May 2, 2022 20:01
@ditman ditman changed the title Removed unused Flutter dependencies to the cross_file package. Can no… [cross_file] Remove unneeded flutter dependency. May 2, 2022
@ditman
Copy link
Member

ditman commented May 4, 2022

Let me update this to pick up the latest CI changes.

tomassasovsky and others added 2 commits May 3, 2022 18:26
@tomassasovsky @ditman
Removed unused Flutter dependencies to the cross_file package. Can no…
a23166c 
…w be imported and used from other Dart packages without the need of making it a Flutter package
@ditman
Add note about testing the package, now that it doesn't use flutter t…
04d8118 
…est.
@ditman
Copy link
Member

ditman commented May 4, 2022 •
edited
Loading

I can manually run the unit tests on this package (I've updated the README to mention running tests without using flutter, which is "not normal" in the flutter plugins/packages ecosystem):

dit@dit:~/github/packages/packages/cross_file$ dart test
00:00 +11: All tests passed!                                                                                                                     

dit@dit:~/github/packages/packages/cross_file$ dart test -p chrome
00:06 +0: compiling test/x_file_html_test.dart                                                                                                   
Info: Compiling with sound null safety
Compiled 10,787,299 characters Dart to 1,331,351 characters JavaScript in 5.66 seconds
Dart file /tmp/dart_test_MZVUER/runInBrowser.dart compiled to JavaScript: /tmp/dart_test_MACBWB/test_GHDLWR/x_file_html_test.dart.browser_test.dart.js

00:07 +13: All tests passed!

Verified tests with package:camera and package:image_picker from flutter/plugins too.

ditman
ditman approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's go!

@ditman
Copy link
Member

ditman commented May 4, 2022

@tomassasovsky again: very useful contribution, thank you very much for it! Keep them coming!

@fluttergithubbot
Copy link

fluttergithubbot commented May 4, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@tomassasovsky
Copy link
Contributor Author

tomassasovsky commented May 4, 2022

Thank you so much @ditman! Will do!

@ditman ditman requested a review from stuartmorgan-g May 4, 2022 02:29
@ditman
Copy link
Member

ditman commented May 4, 2022

/cc @stuartmorgan we need two LGTMs for this one, since this is @tomassasovsky's first contribution.

stuartmorgan-g
stuartmorgan-g requested changes May 4, 2022
View reviewed changes
@ditman ditman requested a review from stuartmorgan-g May 4, 2022 18:39
stuartmorgan-g
stuartmorgan-g approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 4421c15 into flutter:main May 4, 2022
@tomassasovsky
Copy link
Contributor Author

tomassasovsky commented May 4, 2022

TYSM @ditman @stuartmorgan!

@ditman ditman mentioned this pull request May 4, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@ditman ditman ditman approved these changes

Assignees

No one assigned

Labels

p: cross_file waiting for tree to go green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cross_file] Remove unused Flutter dependencies.

4 participants

@tomassasovsky @ditman @fluttergithubbot @stuartmorgan-g