Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[go_router] [test-exempt] Use make-deps-path-based script for analysis and tests#2252

Merged
johnpryan merged 26 commits intomainfrom
remove-path-deps-go-router
Jun 24, 2022
Merged

[go_router] [test-exempt] Use make-deps-path-based script for analysis and tests#2252
johnpryan merged 26 commits intomainfrom
remove-path-deps-go-router

Conversation

@johnpryan
Copy link
Contributor

@johnpryan johnpryan commented Jun 15, 2022 •
edited
Loading

Fixes flutter/flutter#105246

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@johnpryan johnpryan changed the title Remove path deps go router [go_router] Use make-deps-path-based script for analysis and tests Jun 15, 2022
@johnpryan
Copy link
Contributor Author

johnpryan commented Jun 15, 2022

I re-introduced the failure from last time (08a58be) to see if it is caught, but the test in go_router_builder/example should fail. It looks like make-deps-path-based is skipping go_router_builder:

./script/tool_runner.sh make-deps-path-based --target-dependencies-with-non-breaking-updates
Finding changed packages relative to "f43028154b06b7f7411e56442644fdb577be7003"...
  Skipping go_router_builder; no non-breaking version change.

@johnpryan johnpryan marked this pull request as ready for review June 15, 2022 22:05
kevmoo
kevmoo reviewed Jun 15, 2022
View reviewed changes
stuartmorgan-g
stuartmorgan-g requested changes Jun 17, 2022
View reviewed changes
packages/go_router_builder/example/pubspec.yaml Outdated
# Uses path dependency override
go_router: any
go_router:
path: ../../go_router
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using a pub dependency, as discussed previously. We should not have cross-package path-based dependencies. Remove this was the point of this PR if the PR is supposed to fix the linked issue.

(I'm not sure what the goal of adding make-deps-path-based even would be if you were to leave this.)

Copy link
Contributor Author

@johnpryan johnpryan Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I changed it back: 7924bb2.

@kevmoo feel free to jump in here, but it seems like this should be okay for most people, who probably just want to download and run the example, since main matches the latest release.

@johnpryan
Copy link
Contributor Author

johnpryan commented Jun 21, 2022

@stuartmorgan do you know why fetching packages in go_router_builder is timing out on CirrusCI?

@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Jun 21, 2022

For some reason resolution conflicts show up as timeouts in CI; it's super annoying. Since it's only the legacy bots, it's likely that you have some package A that doesn't say it requires Flutter 3.0+, but is depending on a package B that does require 3.0+, so it can't resolve.

You should be able to repro by locally switching your Flutter checkout to the 2.10.5 tag and then running flutter pub get in the failing package, and you'll see the specific error.

stuartmorgan-g
stuartmorgan-g reviewed Jun 21, 2022
View reviewed changes
@johnpryan
Copy link
Contributor Author

johnpryan commented Jun 21, 2022

Thanks for the help, I think is is ready for another look

stuartmorgan-g
stuartmorgan-g requested changes Jun 22, 2022
View reviewed changes
packages/go_router_builder/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 1.0.6

- Use path-based deps in example
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to follow https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verb form is still incorrect; it should be "Uses".

@johnpryan
Copy link
Contributor Author

johnpryan commented Jun 22, 2022

@stuartmorgan This should be ready for another look. The tool_runner.sh adds the --packages-for-branch flag, and I was getting an error saying that only one of --packages, --run-on-changed-packages, or --packages-for-branch can be provided, so I decided to bypass tool_runner.sh in order to use the --run-on-dirty-packages flag (53afd3a).

stuartmorgan-g
stuartmorgan-g requested changes Jun 23, 2022
View reviewed changes
@johnpryan
Copy link
Contributor Author

johnpryan commented Jun 23, 2022 •
edited
Loading

@stuartmorgan Do you know why the pathified_* steps aren't running?

Screen Shot 2022-06-23 at 10 41 46 AM

EDIT: this is behaving as expected since go_router was unmodified

@johnpryan
Copy link
Contributor Author

johnpryan commented Jun 23, 2022

@stuartmorgan this is ready for another look

stuartmorgan-g
stuartmorgan-g approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two nits addressed.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 24, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@johnpryan johnpryan changed the title [go_router] Use make-deps-path-based script for analysis and tests [go_router] [test-exempt] Use make-deps-path-based script for analysis and tests Jun 24, 2022
@johnpryan johnpryan merged commit 0ba5e0c into main Jun 24, 2022
@johnpryan johnpryan deleted the remove-path-deps-go-router branch June 24, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevmoo kevmoo kevmoo left review comments

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

needs tests p: go_router_builder

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove path-based dependencies in go_router_builder/example

3 participants

@johnpryan @stuartmorgan-g @kevmoo