Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[pigeon] Fix style issues in C++ code#2349

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
stuartmorgan-g:pigeon-windows-style
Jul 21, 2022
Merged

[pigeon] Fix style issues in C++ code#2349
auto-submit[bot] merged 2 commits intoflutter:mainfrom
stuartmorgan-g:pigeon-windows-style

Conversation

@stuartmorgan-g
Copy link
Collaborator

Fixes some style issues in helper classes:

  • ErrorOr's field now has the trailing _.
  • ErrorOr::hasError has been renamed to has_error.
  • FlutterError's fields are now private, with the trailing _, and have public accessors.

Fixes flutter/flutter#106438

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Copy link
Contributor

@azchohfi azchohfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2022
@auto-submit auto-submit bot merged commit 9524154 into flutter:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: pigeon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pigeon] C++ generated FlutterError and ErrorOr violate style

2 participants