-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ci] Cirrus pre-alignment with flutter/plugins, part 1 #2706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 17 commits into
flutter:main
from
stuartmorgan-g:cirrus-pre-align-part-1
Oct 19, 2022
Merged
[ci] Cirrus pre-alignment with flutter/plugins, part 1 #2706
auto-submit
merged 17 commits into
flutter:main
from
stuartmorgan-g:cirrus-pre-align-part-1
Oct 19, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me, but I don't know much about cirrus or it's configs, so I'd wait for @bparrishMines if you want a real review, up to you. :)
bparrishMines
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates .cirrus.yaml to better match flutter/plugins, as a step toward eventually merging the repsositories. Changes include:
stable
in addition tomaster
, which was missing only as an oversight.stable
, as we now do in the plugins repo.Since analysis now runs on stable, one analysis option that's not on stable yet had to be commented out.