[extension_google_sign_in_as_googleapis_auth] Move from flutter/plugins.#301
Merged
ditman merged 21 commits intoflutter:masterfrom Mar 9, 2021
Merged
[extension_google_sign_in_as_googleapis_auth] Move from flutter/plugins.#301ditman merged 21 commits intoflutter:masterfrom
ditman merged 21 commits intoflutter:masterfrom
Conversation
Introduce the first version of the `extension_google_sign_in_as_googleapis_auth` package. This package lets users of the `google_sign_in` plugin to create an authenticated HTTP clients (from `googleapis_auth`) that can access any APIs from the `googleapis` package.
* Make package:e2e a relative reference
* e2e -> integration_test and associated version bumps
This cleans up a number of unnecessary differences in the LICENSE files:
- Removes C++ comments ("// ") from the beginnings of all the lines in license files that had them.
- Standardizes on having a blank line after the copyright line.
- Standardizes on having the final newline in the file.
- Standardizes on the indentation of the bulleted conditions.
- Standardizes on the locations of line breaks (re-wrapping the text)
This makes the license bodies--not including the copyright line--in almost all files the same, and matches the exact formatting already used in flutter/flutter and flutter/engine.
The only remaining non-copyright-line differences should now be:
- packages/image_picker/image_picker/LICENSE has an extra license
- packages/google_sign_in/extension_google_sign_in_as_googleapis_auth/LICENSE use "Google LLC" rather than "Google Inc." in the third condition.
Update Flutter SDK constraint to match templates.
…lutter#3642) Migrates to NNBD. Replaces Mockito-based fakes with test's Fake.
…ension/plugins into move-extension
Collaborator
Something I'm going to work on fixing :) |
stuartmorgan-g
requested changes
Mar 8, 2021
packages/extension_google_sign_in_as_googleapis_auth/pubspec.yaml
Outdated
Show resolved
Hide resolved
packages/extension_google_sign_in_as_googleapis_auth/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Member
Author
|
|
ditman
commented
Mar 8, 2021
| # This file tracks properties of this Flutter project. | ||
| # Used by Flutter tool to assess capabilities and perform upgrades etc. | ||
| # | ||
| # This file should be version controlled and should not be manually edited. |
Member
Author
There was a problem hiding this comment.
Should it? I don't remember consciously adding this file :/
Member
Author
|
I'll merge this via the command-line, so the history of the package is preserved, instead of squashing everything in a single commit. |
Member
Author
|
The unrelated history before the "Move to flutter/packages" commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package doesn't make much sense in flutter/plugins, since it's not a true plugin, only an optional extension on google_sign_in.
Testing infrastructure has a hard time in flutter/plugins with this package.
It seems that flutter/packages might be a better home for the extension.
This PR moves the package to flutter/packages, and only minimally changes code to comply with the slightly different analysis rules of this repo.
Pre-launch Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy.CHANGELOG.mdto add a description of the change.///).If you need help, consider asking for advice on the
#hackers-newchannel on Discord.