[extension_google_sign_in_as_googleapis_auth] Update example...#311
[extension_google_sign_in_as_googleapis_auth] Update example...#311ditman merged 2 commits intoflutter:masterfrom kevmoo:extension_google_sign_in_as_googleapis_auth_fixes
Conversation
There was a problem hiding this comment.
email doesn't seem to be needed...
There was a problem hiding this comment.
I thought both 'profile' and 'email' were required to sign in, but not seeing profile there is suspicious :P let me run this example real quick!
https://developers.google.com/identity/protocols/oauth2/scopes#google-sign-in
There was a problem hiding this comment.
('profile', 'email' and 'openid' seem to get added by the google sign-in API automatically if absent from the original request, good!)
There was a problem hiding this comment.
I've been running it all weekend – no issues!
Make GoogleSignIn instance final To use scope from the People API Remove x bit from readme and pubspec.yaml Add link to root repo README
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@ditman – am I okay to land this? |
|
The latest changes have been published to pub.dev as 2.0.2: https://pub.dev/packages/extension_google_sign_in_as_googleapis_auth/changelog#202 |
...to use scope from the People API
Remove x bit from readme and pubspec.yaml
Add link to root repo README
Pre-launch Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy].CHANGELOG.mdto add a description of the change.///).