Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[pigeon] Removed my name from the readme #3395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2023
Merged

[pigeon] Removed my name from the readme #3395

merged 2 commits into from
Mar 8, 2023

Conversation

gaaclarke
Copy link
Member

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke requested a review from tarrinneal as a code owner March 6, 2023 18:35
@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Mar 6, 2023
@stuartmorgan-g
Copy link
Contributor

Overriding checks since we release Pigeon updates fairly often, so this will go out soon without needing a release just for it.

stuartmorgan-g
stuartmorgan-g reviewed Mar 6, 2023
View reviewed changes
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2023
@stuartmorgan-g stuartmorgan-g merged commit 4aa259a into flutter:main Mar 8, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
4aa259a [pigeon] Removed gaaclarke from the readme (flutter/packages#…
4acdcd0 
…3395)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
4aa259a [pigeon] Removed gaaclarke from the readme (flutter/packages#…
1ac1f52 
…3395)
@reidbaker reidbaker mentioned this pull request Mar 20, 2023
Merged
10 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@gaaclarke @nploi
[pigeon] Removed gaaclarke from the readme (flutter#3395)
ecb13ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: pigeon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaaclarke @stuartmorgan-g @tarrinneal