Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[google_maps_flutter] Enable -Werror for Android #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2023
Merged

[google_maps_flutter] Enable -Werror for Android #3399

merged 3 commits into from
Mar 7, 2023

Conversation

stuartmorgan-g
Copy link
Contributor

Enables -Werror in the Java compile step, and fixes or suppresses the resulting errors.

Part of flutter/flutter#91868

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g stuartmorgan-g mentioned this pull request Mar 7, 2023
Closed
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2023
@auto-submit auto-submit bot merged commit c90d823 into flutter:main Mar 7, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
c90d823 [google_maps_flutter] Enable -Werror for Android (flutter/pac…
b3e2785 
…kages#3399)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
c90d823 [google_maps_flutter] Enable -Werror for Android (flutter/pac…
ade1d8b 
…kages#3399)
@reidbaker reidbaker mentioned this pull request Mar 20, 2023
Merged
10 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@stuartmorgan-g @nploi
[google_maps_flutter] Enable -Werror for Android (flutter#3399)
22ec89b 
[google_maps_flutter] Enable -Werror for Android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@camsim99 camsim99 Awaiting requested review from camsim99

@gmackall gmackall Awaiting requested review from gmackall

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@tarrinneal tarrinneal Awaiting requested review from tarrinneal

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @reidbaker