Update tests to ignore deprecated_member_use where TestWindow API is used
#3485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested changes
Mar 20, 2023
packages/dynamic_layouts/example/test/staggered_example_test.dart
Outdated
Show resolved
Hide resolved
Should we add that to the analyzer script? Or would this maybe be a good lint? |
|
If there were a way to configure the analyzer in analysis_options.yaml to only allow specific ignores to be file-level that would be something we could enable; I don't think it's enough of an issue to write our own file parser to do it manually absent that though. |
reidbaker
approved these changes
Mar 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 21, 2023
…dow` API is used (flutter/packages#3485)
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
… is used (flutter#3485) Update tests to ignore `deprecated_member_use` where `TestWindow` API is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests to ignore
deprecated_member_usewhereTestWindowAPI is used.With #122824, the
TestWindowAPI is deprecated. We need to ignore analysis errors from using deprecated members for CI to work, but don't want to update the API until 3.9.0 is in stable.#122912 tracks the eventual migration to the new
TestFlutterViewAPI.Progress towards #121915.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).