[video_player] added iOS exception on incorrect asset path #4318

zopagaduanjr · 2023-06-26T23:50:30Z

surfaced the incorrect asset path error to dart using try catch.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-06-26T23:50:33Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

hellohuanlin

Can you add some description with the exception logs before and after your change.

packages/video_player/video_player_avfoundation/CHANGELOG.md

hellohuanlin · 2023-06-28T00:03:05Z

packages/video_player/video_player_avfoundation/ios/Classes/FLTVideoPlayerPlugin.m

+                                         playerFactory:_playerFactory];
+        return [self onPlayerSetup:player frameUpdater:frameUpdater];
+    }
+    @catch (NSException *exception) {


did it crash before when the exception is thrown?

for ios yes. using the code sample of flutter/flutter#118660 (comment), it should crash and look like this

zopagaduanjr · 2023-06-28T13:37:11Z

current exception logs when asset path is incorrect

Lost connection to device.
Exception: Unable to terminate com.example.delete on 3665098C-8CA5-41DD-9915-520BC16A4457:
ProcessException: Process exited abnormally:
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=3):
Simulator device returned an error for the requested operation.
found nothing to terminate
Underlying error (domain=NSPOSIXErrorDomain, code=3):
	The operation couldn’t be completed. found nothing to terminate
	found nothing to terminate
  Command: /usr/bin/arch -arm64e xcrun simctl terminate 3665098C-8CA5-41DD-9915-520BC16A4457 com.example.delete
Failed to send request: {"jsonrpc":"2.0","id":"21","method":"getObject","params":{"isolateId":"isolates/842831092504847","objectId":"libraries/@609171358"}}

zopagaduanjr · 2023-06-28T13:42:06Z

the proposed try catch update will now raise a platformException, and will not instantly crash the app

[VERBOSE-2:dart_vm_initializer.cc(41)] Unhandled Exception: PlatformException(video_player, *** -[NSURL initFileURLWithPath:]: nil string parameter, null, null)
#0      AVFoundationVideoPlayerApi.create (package:video_player_avfoundation/src/messages.g.dart:298:7)
<asynchronous suspension>
#1      AVFoundationVideoPlayer.create (package:video_player_avfoundation/src/avfoundation_video_player.dart:65:37)
<asynchronous suspension>
#2      VideoPlayerController.initialize (package:video_player/video_player.dart:404:19)
<asynchronous suspension>

hellohuanlin

looks like a good change. can you add some tests?

packages/video_player/video_player_avfoundation/test/avfoundation_video_player_test.dart

hellohuanlin · 2023-07-04T00:21:33Z

packages/video_player/video_player_avfoundation/test/avfoundation_video_player_test.dart

+      try {
+        await player.create(DataSource(
+          sourceType: DataSourceType.asset,
+          asset: 'incorrectAsset',


nit: can you make it look more like a path, e.g. /path/to/incorrect_asset

tarrinneal

You'll need to run the format command dart pub global run flutter_plugin_tools format --packages video_player before this can land.

zopagaduanjr · 2023-07-11T13:00:52Z

finished running the format command

tarrinneal

lgtm with one small change.

packages/video_player/video_player_avfoundation/test/avfoundation_video_player_test.dart

…lutter/packages#4318)

flutter/packages@aa1eace...369ee7e 2023-07-14 [email protected] [Tool] New tool to download android dependencies (flutter/packages#4408) 2023-07-14 [email protected] [video_player] added iOS exception on incorrect asset path (flutter/packages#4318) 2023-07-14 [email protected] [google_maps_flutter_platform_interface] Add support for cloud-based map styling (flutter/packages#4141) 2023-07-14 [email protected] [webview_flutter] Adds support for receiving a url with WebResourceError (flutter/packages#3884) 2023-07-14 [email protected] [xdg_directories] Remove `process` dependency (flutter/packages#4460) 2023-07-13 [email protected] [various] Update Pigeon in Swift plugins (flutter/packages#4461) 2023-07-13 [email protected] Roll Flutter from 544d30d to c40173f (10 revisions) (flutter/packages#4457) 2023-07-13 [email protected] Roll Flutter (stable) from 796c8ef to f468f33 (2 revisions) (flutter/packages#4456) 2023-07-13 [email protected] Fix Router Config Issues #4300 (go_router_builder/example) (flutter/packages#4369) 2023-07-13 [email protected] [webview_flutter_platform_interface] Adds url to `WebResourceError` (flutter/packages#4439) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/packages@aa1eace...369ee7e 2023-07-14 [email protected] [Tool] New tool to download android dependencies (flutter/packages#4408) 2023-07-14 [email protected] [video_player] added iOS exception on incorrect asset path (flutter/packages#4318) 2023-07-14 [email protected] [google_maps_flutter_platform_interface] Add support for cloud-based map styling (flutter/packages#4141) 2023-07-14 [email protected] [webview_flutter] Adds support for receiving a url with WebResourceError (flutter/packages#3884) 2023-07-14 [email protected] [xdg_directories] Remove `process` dependency (flutter/packages#4460) 2023-07-13 [email protected] [various] Update Pigeon in Swift plugins (flutter/packages#4461) 2023-07-13 [email protected] Roll Flutter from 544d30d to c40173f (10 revisions) (flutter/packages#4457) 2023-07-13 [email protected] Roll Flutter (stable) from 796c8ef to f468f33 (2 revisions) (flutter/packages#4456) 2023-07-13 [email protected] Fix Router Config Issues flutter#4300 (go_router_builder/example) (flutter/packages#4369) 2023-07-13 [email protected] [webview_flutter_platform_interface] Adds url to `WebResourceError` (flutter/packages#4439) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

zopagaduanjr requested a review from hellohuanlin as a code owner June 26, 2023 23:50

flutter-dashboard bot added the needs tests label Jun 26, 2023

github-actions bot added p: video_player platform-ios labels Jun 26, 2023

zopagaduanjr force-pushed the video_player/ios-asset-exception branch from d797b43 to 69fef98 Compare June 27, 2023 09:10

hellohuanlin reviewed Jun 28, 2023

View reviewed changes

zopagaduanjr force-pushed the video_player/ios-asset-exception branch from 69fef98 to 330b347 Compare June 28, 2023 13:32

hellohuanlin reviewed Jun 28, 2023

View reviewed changes

zopagaduanjr force-pushed the video_player/ios-asset-exception branch from 997fa36 to 2d1162b Compare June 29, 2023 05:56

zopagaduanjr commented Jun 29, 2023

View reviewed changes

packages/video_player/video_player_avfoundation/test/avfoundation_video_player_test.dart Show resolved Hide resolved

zopagaduanjr force-pushed the video_player/ios-asset-exception branch from 2d1162b to ebcf0e3 Compare July 1, 2023 00:39

hellohuanlin approved these changes Jul 4, 2023

View reviewed changes

zopagaduanjr force-pushed the video_player/ios-asset-exception branch 2 times, most recently from 2a306b5 to 4ecf1df Compare July 6, 2023 04:19

stuartmorgan-g requested a review from tarrinneal July 10, 2023 19:18

tarrinneal requested changes Jul 10, 2023

View reviewed changes

zopagaduanjr force-pushed the video_player/ios-asset-exception branch from 4ecf1df to e632d70 Compare July 11, 2023 12:27

zopagaduanjr force-pushed the video_player/ios-asset-exception branch from 9420170 to 7840012 Compare July 12, 2023 08:46

tarrinneal requested changes Jul 12, 2023

View reviewed changes

packages/video_player/video_player_avfoundation/test/avfoundation_video_player_test.dart Outdated Show resolved Hide resolved

zopagaduanjr added 6 commits July 13, 2023 09:39

added iOS exception on incorrect asset path

cf011a5

updated changelog

6552088

added incorrect asset test

3b1a4c2

updated test

f6456f3

updated test

5f1564b

ran format command

9e77817

zopagaduanjr force-pushed the video_player/ios-asset-exception branch from 7840012 to 9e77817 Compare July 13, 2023 01:39

updated test

9e1c8f2

tarrinneal approved these changes Jul 14, 2023

View reviewed changes

tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2023

auto-submit bot merged commit 4c11497 into flutter:main Jul 14, 2023

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Packages from aa1eace00188 to 4c1149744dbb (9 revisions) flutter/flutter#130582

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2023

4c11497 [video_player] added iOS exception on incorrect asset path (f…

8228771

…lutter/packages#4318)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Packages from aa1eace00188 to 369ee7e1a1cb (10 revisions) flutter/flutter#130592

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2023

4c11497 [video_player] added iOS exception on incorrect asset path (f…

e4ff4c3

…lutter/packages#4318)

reidbaker mentioned this pull request Jul 14, 2023

[tooling] mark infra steps as infra steps in yaml files #4473

Merged

11 tasks

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Packages from aa1eace00188 to 369ee7e1a1cb (10 revisions) flutter/flutter#130605

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2023

4c11497 [video_player] added iOS exception on incorrect asset path (f…

b2328a8

…lutter/packages#4318)

reidbaker mentioned this pull request Jul 26, 2023

[Tooling] Add google owned cache for dependencies as an option in ci #4567

Merged

11 tasks

reidbaker mentioned this pull request Aug 4, 2023

[All] Expand artifact hub to all plugins #4645

Merged

11 tasks

FirentisTFW mentioned this pull request Jan 15, 2025

[video_player_avfoundation] iOS platform view support #8237

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[video_player] added iOS exception on incorrect asset path #4318

[video_player] added iOS exception on incorrect asset path #4318

zopagaduanjr commented Jun 26, 2023

flutter-dashboard bot commented Jun 26, 2023

hellohuanlin left a comment

hellohuanlin Jun 28, 2023

zopagaduanjr Jun 28, 2023

zopagaduanjr commented Jun 28, 2023

zopagaduanjr commented Jun 28, 2023

hellohuanlin left a comment

hellohuanlin Jul 4, 2023

tarrinneal left a comment

zopagaduanjr commented Jul 11, 2023

tarrinneal left a comment

[video_player] added iOS exception on incorrect asset path #4318

[video_player] added iOS exception on incorrect asset path #4318

Conversation

zopagaduanjr commented Jun 26, 2023

Pre-launch Checklist

flutter-dashboard bot commented Jun 26, 2023

hellohuanlin left a comment

Choose a reason for hiding this comment

hellohuanlin Jun 28, 2023

Choose a reason for hiding this comment

zopagaduanjr Jun 28, 2023

Choose a reason for hiding this comment

zopagaduanjr commented Jun 28, 2023

zopagaduanjr commented Jun 28, 2023

hellohuanlin left a comment

Choose a reason for hiding this comment

hellohuanlin Jul 4, 2023

Choose a reason for hiding this comment

tarrinneal left a comment

Choose a reason for hiding this comment

zopagaduanjr commented Jul 11, 2023

tarrinneal left a comment

Choose a reason for hiding this comment