Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Roll pigeon dependency to unblock flutter framework deps roll #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 7, 2023
Merged

Roll pigeon dependency to unblock flutter framework deps roll #4383

merged 11 commits into from
Jul 7, 2023

Conversation

aam
Copy link
Member

@aam aam commented Jul 5, 2023 •
edited
Loading

Update pigeon dependency for url_launcher_windows.

This is required to unblock flutter dependency update - see flutter/flutter#130032

@aam aam requested a review from cbracken as a code owner July 5, 2023 22:31
@aam
Copy link
Member Author

aam commented Jul 5, 2023

cc @zanderso

@zanderso zanderso requested a review from stuartmorgan-g July 6, 2023 14:55
stuartmorgan-g
stuartmorgan-g requested changes Jul 6, 2023
View reviewed changes
packages/url_launcher/url_launcher_windows/CHANGELOG.md Outdated

* Update pigeon dependency for url_launcher_windows to "^9.2.4".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Updates

Per repo style guide.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/url_launcher/url_launcher_windows/pubspec.yaml Outdated
@@ -24,5 +24,5 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
pigeon: ^5.0.1
pigeon: ^9.2.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pigeon is a code generator, so updates to it need to update the generated code. Running update-dependency --pub-package=pigeon --packages/url_launcher_windows via the repo tooling will do the right thing.

(Generally we want to update to the latest Pigeon, but if you really need 9.2.4 for some reason you can add --version=9.2.4)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main reason I chose 9.2.4 was that it is the version that is used by other url_launcher. Going to the latest for this package works too. Of course it is possible to rev up pigeon across all plugins, but I tried to minimize the scope of the change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pigeon is a code generator, so updates to it need to update the generated code. Running update-dependency --pub-package=pigeon --packages/url_launcher_windows via the repo tooling will do the right thing.

This hasn't been addressed; the generated code update is still not part of the PR.

@stuartmorgan-g stuartmorgan-g mentioned this pull request Jul 6, 2023
Merged
11 tasks
@aam aam mentioned this pull request Jul 6, 2023
Closed
@aam aam requested a review from stuartmorgan-g July 6, 2023 21:52
auto-submit bot pushed a commit that referenced this pull request Jul 6, 2023
@stuartmorgan-g
[local_auth] Update Windows Pigeon version (#4388)
3fec7e8 
Updates to the latest version of Pigeon.

This is largely a no-op, the generated output changes are formatting tweaks and picking up one bugfix to the error code/message ordering. The goal here is just to be using a newer version of Pigeon to minimize future dependency issues along the lines of #4383
stuartmorgan-g
stuartmorgan-g requested changes Jul 6, 2023
View reviewed changes
packages/url_launcher/url_launcher_windows/pubspec.yaml Outdated
@@ -24,5 +24,5 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
pigeon: ^5.0.1
pigeon: ^9.2.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pigeon is a code generator, so updates to it need to update the generated code. Running update-dependency --pub-package=pigeon --packages/url_launcher_windows via the repo tooling will do the right thing.

This hasn't been addressed; the generated code update is still not part of the PR.

@aam
Copy link
Member Author

aam commented Jul 7, 2023

@stuartmorgan said:

This hasn't been addressed; the generated code update is still not part of the PR.

Ah, I didn't realize that as I ran the command it reported errors:

─➤  PATH=$FH/flutter/bin:$PATH dart run script/tool/bin/flutter_plugin_tools.dart  update-dependency --pub-package=pigeon --packages=url_launcher_windows
Running for url_launcher_windows...
  Updating to "^10.1.2"
  Running pub get...
dart pub get failed (1):
Resolving dependencies...

Because url_launcher_windows requires the Flutter SDK, version solving failed.

Flutter users should run `flutter pub get` instead of `dart pub get`.


Running for url_launcher_windows/example...
  SKIPPING: Does not depend on pigeon


The following packages had errors:
  url_launcher_windows:
    Failed to update pigeon files
See above for full details.

aam added 2 commits July 6, 2023 19:33
@stuartmorgan-g
Copy link
Contributor

Odd, I've never seen that when updating plugin dependencies with the script. I'm not sure why the behavior isn't consistent, but I can fix the call tomorrow.

@aam
Copy link
Member Author

aam commented Jul 7, 2023

Odd, I've never seen that when updating plugin dependencies with the script. I'm not sure why the behavior isn't consistent, but I can fix the call tomorrow.

I hacked the script so it ran flutter pub get and it seems to have worked.

@aam aam requested a review from stuartmorgan-g July 7, 2023 16:29
stuartmorgan-g
stuartmorgan-g approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aam
Copy link
Member Author

aam commented Jul 7, 2023

LGTM

Is submit-queue failure relevant? It seems to report failure on android tests, which seems to have been skipped.

@aam aam merged commit b61eea1 into flutter:main Jul 7, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2023
@engine-flutter-autoroll
b61eea1 Roll pigeon dependency to unblock flutter framework deps roll (…
44119ff 
…flutter/packages#4383)
@stuartmorgan-g
Copy link
Contributor

Is submit-queue failure relevant? It seems to report failure on android tests, which seems to have been skipped.

submit-queue is the tree status, and when you clicked through you were seeing the post-submit status of the last thing that landed in the tree. It's in PRs to prevent people from landing PRs while the tree is red.

Please don't ever land a PR with red checks in a flutter/* unless you have explicit permission from a relevant lead or gardener.

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 7, 2023
@engine-flutter-autoroll
Roll Packages from 9bcf4bf to b61eea1 (1 revision) (#130154)
f2e281f 
flutter/packages@9bcf4bf...b61eea1

2023-07-07 [email protected] Roll pigeon dependency to unblock flutter framework deps roll (flutter/packages#4383)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 14, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@cbracken cbracken Awaiting requested review from cbracken cbracken is a code owner

Assignees
No one assigned
Labels
p: url_launcher platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aam @stuartmorgan-g