Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[palette_generator] Add PaletteGenerator.fromByteData#450

Merged
gspencergoog merged 4 commits intoflutter:masterfrom
nt4f04uNd:palette-bytedata
Sep 1, 2021
Merged

[palette_generator] Add PaletteGenerator.fromByteData#450
gspencergoog merged 4 commits intoflutter:masterfrom
nt4f04uNd:palette-bytedata

Conversation

@nt4f04uNd
Copy link
Member

@nt4f04uNd nt4f04uNd commented Aug 29, 2021

Fixes flutter/flutter#28383

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Aug 29, 2021
@nt4f04uNd
Copy link
Member Author

nt4f04uNd commented Sep 1, 2021

In discord @gspencergoog said

As for the isolate, ideally it would be optional, but if it's easier to just always create it, then go ahead and do that.

I just checked and unfortunately currently spawn the isolate internally is not possible, because filters are closures, which cannot be sent over isolates, see dart-lang/sdk#46623 . It is only possible that developer creates his own isolate

@gspencergoog
Copy link
Contributor

gspencergoog commented Sep 1, 2021

Ahh, yes, that is true, I had forgotten about filters.

gspencergoog
gspencergoog approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@nt4f04uNd @gspencergoog
Apply suggestion
481a6ba 
Co-authored-by: Greg Spencer <[email protected]>
@gspencergoog gspencergoog merged commit e3b4b33 into flutter:master Sep 1, 2021
@nt4f04uNd nt4f04uNd deleted the palette-bytedata branch September 4, 2021 15:00
@nt4f04uNd nt4f04uNd mentioned this pull request Oct 8, 2021
Merged
11 tasks
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
@goderbauer
Prepare for dry layout feature (#450)
bd987ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

cla: yes p: palette_generator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

palette_generator block UI thread

2 participants

@nt4f04uNd @gspencergoog