Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adjust pull request template #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2021
Merged

Adjust pull request template #509

merged 3 commits into from
Nov 8, 2021

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Nov 5, 2021

Align the flutter/packages template with recent changes to the flutter/plugins template.

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@stuartmorgan-g
Adjust pull request template
e3dc01b 
Align the flutter/packages template with recent changes to the flutter/plugins template.
@google-cla google-cla bot added the cla: yes label Nov 5, 2021
@stuartmorgan-g stuartmorgan-g requested a review from Hixie November 5, 2021 18:45
Hixie
Hixie approved these changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm fine either way, but did you intend to remove the backticks around file names etc?

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Nov 6, 2021

I'm fine either way, but did you intend to remove the backticks around file names etc?

Nope, apparently we didn't have it flutter/plugins, but did here. I think it's better, so I'll add it back here and change the flutter/plugins PR to match.

@stuartmorgan-g stuartmorgan-g merged commit 70d2ffb into master Nov 8, 2021
@stuartmorgan-g stuartmorgan-g deleted the adjust-pull-request-template branch November 8, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuartmorgan-g @Hixie