[pigeon] Fix too little information when having an exception#545
[pigeon] Fix too little information when having an exception#545gaaclarke merged 8 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@fzyzcjy For making this publishable you'll have to update the version of pigeon in pubspec.yaml and update the CHANGELOG.md. For the test, i think this is close to what you want: https://github.com/gaaclarke/packages/blob/6529013ca4619ac0f1d6690a1cf0b98cabc75823/packages/pigeon/platform_tests/android_unit_tests/android/app/src/test/java/com/example/android_unit_tests/PigeonTest.java#L57:L57 Those tests generate the java code then run unit tests on them. You'll just want to set a handler that throws and exception and look into the details section to make sure your info exists. |
Sure. Just want to finish test first before this
Thanks |
|
@gaaclarke tests passed |
|
@gaaclarke You are welcome! |
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Fix flutter/flutter#96027
Please see #543
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.