[pigeon] Support other hosts in generated file CI checks #5944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
11 tasks
|
test-exempt: is a test |
jmagman
approved these changes
Jan 19, 2024
packages/pigeon/tool/run_tests.dart
Outdated
| }; | ||
| } else if (Platform.isMacOS) { | ||
| languagesToValidate = <GeneratorLanguage>{ | ||
| // TODO(stuartmorgan): Enable this in or after https://github.com/flutter/packages/pull/5928 |
tarrinneal
reviewed
Jan 20, 2024
packages/pigeon/tool/run_tests.dart
Outdated
Comment on lines
141
to
146
| GeneratorLanguage.cpp => <String>{'cc', 'cpp', 'h'}, | ||
| GeneratorLanguage.dart => <String>{'dart'}, | ||
| GeneratorLanguage.java => <String>{'java'}, | ||
| GeneratorLanguage.kotlin => <String>{'kt'}, | ||
| GeneratorLanguage.swift => <String>{'swift'}, | ||
| GeneratorLanguage.objc => <String>{'m', 'mm'}, |
There was a problem hiding this comment.
how are we handling .h files for objc?
There was a problem hiding this comment.
Oops! They should be listed here; having duplicates will be fine since.
tarrinneal
approved these changes
Jan 20, 2024
|
changelog override: the only non-test change is formatting of an example file, which isn't going to be interesting to clients. |
|
version override: quick_actions code changes are just formatting, so do not affect clients. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 22, 2024
flutter/packages@129e08c...e4cbf23 2024-01-21 [email protected] Roll Flutter from ddf60fb to 5dea6b9 (5 revisions) (flutter/packages#5951) 2024-01-21 [email protected] Update platform label rules for shared iOS/macOS (flutter/packages#5801) 2024-01-20 [email protected] [pigeon] Support other hosts in generated file CI checks (flutter/packages#5944) 2024-01-20 [email protected] [pigeon] Improve style of generated Swift code (flutter/packages#5938) 2024-01-20 [email protected] Roll Flutter from 684247a to ddf60fb (12 revisions) (flutter/packages#5949) 2024-01-20 [email protected] [camera]fix a sample buffer memory leak on pause resume recording (flutter/packages#5927) 2024-01-19 [email protected] [ci] Run Swift formatter and linter during CI formatting (flutter/packages#5928) 2024-01-19 [email protected] Manual roll Flutter from f77f824 to 684247a (39 revisions) (flutter/packages#5948) 2024-01-19 [email protected] Expose registered widget libraries and local widget library widgets. (flutter/packages#5936) 2024-01-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.2.0 (flutter/packages#5937) 2024-01-19 [email protected] Manual roll Flutter (stable) from ef1af02 to 67457e6 (1 revision) (flutter/packages#5932) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks Pigeon's CI validation of generated files to support multiple hosts, rather than only Linux, with the ability to set specific languages per host, to allow us to run validation for each language on whatever host it is most convenient to set up a formatter for that language, rather than having to support all languages on Linux.
See discussion in #5928
Part of flutter/flutter#41129
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).