[camera_avfoundation] Add all missing iOS capture device types #5957
Conversation
| } | ||
| if (@available(iOS 17.0, *)) { | ||
| [discoveryDevices addObjectsFromArray: | ||
| @[ AVCaptureDeviceTypeExternal, |
There was a problem hiding this comment.
this will conflict with https://github.com/flutter/packages/pull/5892/files#diff-1c009b8a6867d4f5d1df72811707915498c5fa4ef49caeb85314d7ce13a4fd6dR114
Can you wait till that is landed?
There was a problem hiding this comment.
This PR could replace that one as it still adds the external camera type. I am also just about to make two other PRs that will depend on this one.
|
It's not at all clear to me that adding logical and ephemeral camera types to the discovery process without any changes to the higher-level camera API is a good idea. What are the implications of this on clients? E.g., how will clients know which features are or are not supported on each type, given that the docs for the logical camera types list a bunch of features that aren't supported for them? How will clients know when an ephemeral camera is removed? flutter/flutter#134151 requests new API that this does not provide or have an alternative for, for example. Logical and ephemeral camera types both seem like features that need full design proposals, with discussion of how they will be plumbed through the entire plugin and across platforms, rather than just enabled at on a single platform at the native level without any other changes. /cc @bparrishMines |
|
Marking as a draft pending a design proposal, per comments above. @rickcasson Is that something you are planning on moving forward with? |
@stuartmorgan, yes, still planning on making a design proposal! I will try to finish research into the Android (and other platform) and submit that in the coming weeks. |
|
(triage): I am going to close this one since there hasn't been any follow-up. If you find the time to address the feedback given above please reopen this. Thank you. |
Several of the physical and logical cameras were missing when discovering available capture devices on iOS, so I completed the list based on Apple's developer documentation: https://developer.apple.com/documentation/avfoundation/avcapturedevice/devicetype
@bibaswan-bhawal had previously made a PR (#5892) that added one of these types, but I think it would be helpful to have the complete list available.
List which issues are fixed by this PR. You must list at least one issue.
closes flutter/flutter#134151
closes flutter/flutter#130073
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).