[Camera] Add lens type information (iOS) #8723

lenzpaul · 2025-02-26T21:44:41Z

This PR adds lens type information. The goal is to identify whether the lens type is wide, ultra-wide, telephoto, etc., as discussed in flutter/flutter#119908. The iOS implementation is complete, so lens data will now be populated on iOS.

Introduces a new CameraLensType enum to provide lens type information about the camera (e.g.: ultra-wide, telephoto, ...)
Adds lensType in the PlatformCameraDescription and CameraDescription classes
Implements utility functions to convert between PlatformCameraLensType and CameraLensType.
Updates auto-generated code (using Pigeon) to reflect these changes.

Current CameraDescription for iPhone 11

[
    CameraDescription(
        com.apple.avfoundation.avcapturedevice.built-in_video:0,
        CameraLensDirection.back,
        90
    ),
    CameraDescription(
        com.apple.avfoundation.avcapturedevice.built-in_video:1,
        CameraLensDirection.front,
        90
    ),
    CameraDescription(
        com.apple.avfoundation.avcapturedevice.built-in_video:5,
        CameraLensDirection.back,
        90
    )
]

New CameraDescription for iPhone 11

[
    CameraDescription(
        com.apple.avfoundation.avcapturedevice.built-in_video:0,
        CameraLensDirection.back,
        90,
        CameraLensType.wide
    ),
    CameraDescription(
        com.apple.avfoundation.avcapturedevice.built-in_video:1,
        CameraLensDirection.front,
        90,
        CameraLensType.wide
    ),
    CameraDescription(
        com.apple.avfoundation.avcapturedevice.built-in_video:5,
        CameraLensDirection.back,
        90,
        CameraLensType.ultraWide
    )
]

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Ran format script Fix Package.resolved

…and camera_description.dart

from `/packages/packages/camera` ran `dart run ../../script/tool/bin/flutter_plugin_tools.dart format --current-package`

Removed the changes to the pubspecs in the packages that have no other changes (the Android, web, and Windows)

…8723)

flutter/packages@125c117...07496eb 2025-04-02 [email protected] [multicast_dns] MDnsClient::listen supports onError callback (flutter/packages#8888) 2025-04-02 [email protected] Upgrade tests to use Xcode 16 and iOS 18 (flutter/packages#8968) 2025-04-01 [email protected] Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (flutter/packages#8960) 2025-04-01 [email protected] Drop deprecated HTML head meta tags (flutter/packages#8970) 2025-04-01 [email protected] Adjust PR checklist formatter discussion (flutter/packages#8924) 2025-04-01 [email protected] Update CODEOWNERS username (flutter/packages#8933) 2025-04-01 [email protected] [flutter_markdown] Added sizedImageBuilder to Markdown widget (flutter/packages#6739) 2025-04-01 [email protected] [google_maps_flutter] Skip impl copy of iOS tests (flutter/packages#8975) 2025-04-01 [email protected] [google_maps_flutter] Skip more hanging iOS tests (flutter/packages#8967) 2025-04-01 [email protected] [url_launcher] When not fully loaded, clicking close causes the callback to not be triggered correctly. (flutter/packages#8582) 2025-04-01 [email protected] [camera_avfoundation] Test utils and mocks swift migration - part 2 (flutter/packages#8892) 2025-03-31 [email protected] [webview_flutter] Skip flaky legacy tests on iOS (flutter/packages#8911) 2025-03-31 [email protected] [camera_android] Don't override default fps range when not recording (flutter/packages#8891) 2025-03-31 [email protected] [google_maps_flutter] Fix typo and remove duplicitous CHANGELOG entry (flutter/packages#8754) 2025-03-31 [email protected] [extension_gsi] Support the latest version of googleapis_auth (flutter/packages#8931) 2025-03-31 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#8955) 2025-03-31 [email protected] [webview_flutter_wkwebview] Fixes crash when sending undefined message via javascript channel (flutter/packages#8776) 2025-03-31 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in /packages/pigeon/platform_tests/alternate_language_test_plugin/android (flutter/packages#8946) 2025-03-31 [email protected] [interactive_media_ads] Fixes `AdEventType`s not triggering on iOS in release mode (flutter/packages#8918) 2025-03-31 [email protected] [google_maps_flutter] Skip test that hangs iOS CI (flutter/packages#8958) 2025-03-28 [email protected] Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter/packages#8922) 2025-03-28 [email protected] [camera_avfoundation] Test utils and mocks swift migration - part 3 (flutter/packages#8912) 2025-03-27 [email protected] Use a more deterministic way of waiting for ad widgets to be ready. (flutter/packages#8920) 2025-03-27 [email protected] [camera_avfoundation] Test utils and mocks swift migration - part 1 (flutter/packages#8890) 2025-03-27 [email protected] [pigeon] correct usage of extended generics in generator methods (flutter/packages#8910) 2025-03-27 [email protected] [video_player] Fix layout issue caused by `Transform.rotate` not affecting space calculation. (flutter/packages#8685) 2025-03-27 [email protected] [shared_preferences] Fix a late initialized error with the example app (flutter/packages#8540) 2025-03-26 [email protected] [various] Disable sandbox in Chrome dart tests (flutter/packages#8909) 2025-03-25 [email protected] [tool] Move changed file detection to base command class (flutter/packages#8730) 2025-03-25 [email protected] [Camera] Add lens type information (iOS) (flutter/packages#8723) 2025-03-25 [email protected] [pigeon] kotlin equality methods (flutter/packages#8887) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md --------- Co-authored-by: Maurice Parrish <[email protected]>

…8723)

A unit test in the app-facing package that predates federation is asserting an expected string that includes constant text that is controlled by a `toString` method from the platform interface package. This fixes the test to only assert the parts that are within the package's control. Unblocks flutter/packages#8723 ## Pre-Review Checklist

lenzpaul requested review from hellohuanlin and bparrishMines as code owners February 26, 2025 21:44

github-actions bot added p: camera platform-ios platform-macos labels Feb 26, 2025

lenzpaul mentioned this pull request Feb 26, 2025

[Camera] Add lens type information (iOS) #7653

Open

11 tasks

lenzpaul force-pushed the camera_package_patch_2 branch from 638ccab to e4fedcb Compare February 26, 2025 21:45

hellohuanlin approved these changes Feb 27, 2025

View reviewed changes

lenzpaul added 21 commits March 6, 2025 16:10

add lens type info to camera plugin [ios-only]

dad18b9

run pigeon generator

a53858b

Update tests

6b8fa07

updated versions and Changelogs

e0c743a

adds dependency_overrides for federated plugin PR

78fbe47

Add lens type information to camera plugin tests

2248a71

Add iOS version checks ensuring API availability for camera device types

0bbfd07

Apply formatting fixes

5e347d7

created helper function for lens direction and type

989a270

Change lens type enum to only use UltraWide, Wide, and Telephoto

ba8263a

run pigeon gen and applied flutter_plugin_tools.dart formatting

ae66e57

Update CHANGELOG and Fix CI errors

ec472d7

Ran format script Fix Package.resolved

Fix formatting for CI

9540ef7

Refactor camera lens direction and type handling in CameraPlugin

5a3db31

Fix documentation for camera lens type descriptions in messages.dart …

39aac3c

…and camera_description.dart

run format script

ec7f8f2

from `/packages/packages/camera` ran `dart run ../../script/tool/bin/flutter_plugin_tools.dart format --current-package`

Remove unnecessary pubspec changes

16f9fc4

Removed the changes to the pubspecs in the packages that have no other changes (the Android, web, and Windows)

Remove temporary dependency overrides from pubspec.yaml files

d2404a6

Remove Runner changes

697c023

Updates versions and CHANGELOGs. Runs pigeon generator

8aed9ea

Revert implementation changes in camera_avfoundation

119beaa

lenzpaul force-pushed the camera_package_patch_2 branch from e4fedcb to 119beaa Compare March 6, 2025 21:22

engine-flutter-autoroll mentioned this pull request Mar 31, 2025

Roll Packages from 125c117a432f to 01f977156055 (18 revisions) flutter/flutter#166261

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

ec18417

…8723)

engine-flutter-autoroll mentioned this pull request Mar 31, 2025

Roll Packages from 125c117a432f to c97691715ffb (19 revisions) flutter/flutter#166266

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

cde4874

…8723)

engine-flutter-autoroll mentioned this pull request Mar 31, 2025

Roll Packages from 125c117a432f to c97691715ffb (19 revisions) flutter/flutter#166280

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

3bfd10d

…8723)

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Packages from 125c117a432f to 0ef3d446fd44 (23 revisions) flutter/flutter#166341

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

7cd3250

…8723)

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Packages from 125c117a432f to 799a5908904c (24 revisions) flutter/flutter#166346

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

219a5f2

…8723)

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Packages from 125c117a432f to bba066f89dd4 (25 revisions) flutter/flutter#166349

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

8477d65

…8723)

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Packages from 125c117a432f to 28676de193f2 (26 revisions) flutter/flutter#166352

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

ee7ee78

…8723)

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Packages from 125c117a432f to eb8cb324582e (27 revisions) flutter/flutter#166356

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

0b36dac

…8723)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 84ef201205ea (29 revisions) flutter/flutter#166435

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

a7507dc

…8723)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 5cee1525909d (30 revisions) flutter/flutter#166456

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

c018dd2

…8723)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 07496eb03035 (31 revisions) flutter/flutter#166457

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

efc9d71

…8723)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 07496eb03035 (31 revisions) flutter/flutter#166469

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

2e9c584

…8723)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 8f5844af8135 (32 revisions) flutter/flutter#166472

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2025

c254ecab9 [Camera] Add lens type information (iOS) (flutter/packages#…

36774d5

…8723)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Packages from 125c117a432f to 8f5844af8135 (32 revisions) flutter/flutter#166534

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Camera] Add lens type information (iOS) #8723

[Camera] Add lens type information (iOS) #8723

Uh oh!

lenzpaul commented Feb 26, 2025

Uh oh!

Uh oh!

[Camera] Add lens type information (iOS) #8723

[Camera] Add lens type information (iOS) #8723

Uh oh!

Conversation

lenzpaul commented Feb 26, 2025

Pre-launch Checklist

Uh oh!

Uh oh!