Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[camera_android_camerax] Implement setDescriptionWhileRecording #9878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

[camera_android_camerax] Implement setDescriptionWhileRecording #9878

wants to merge 22 commits into from
+717 −63

Conversation

blackorbs-dev
Copy link

@blackorbs-dev blackorbs-dev commented Aug 24, 2025 •
edited
Loading

setDescriptionWhileRecording allows switching camera while a video recording is in progress. This feature was only working with camera2 setup, but the camera plugin uses camerax by default. So, this PR includes update to address the issue.

Fixes #148013

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3

gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 24, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully implements the ability to switch cameras while recording video on Android by introducing a persistent recording mode. The changes are well-structured across the camera, camera_platform_interface, and camera_android_camerax packages. My review includes a few suggestions to improve the code, such as removing some dead code and improving test practices. Please also remember to remove the temporary dependency_overrides from the various pubspec.yaml files before merging.

@stuartmorgan-g
Copy link
Collaborator

Thanks for the contribution!

All of the changes in camera_android, camera_avfoundation, camera_web, and camera_windows can be reverted, so that this review is scoped to the right set of package reviewers.

  • All existing and new tests are passing.

The native test suites do not currently build; please see the CI failure output and resolve the failures.

stuartmorgan-g added a commit that referenced this pull request Aug 25, 2025
@stuartmorgan-g
Try to convince GCA to stop complaining about dependency_overrides
7362b25 
Adds a section to the review agent configuration to try to get it to stop leaving comments like [this one](#9878 (comment)) on federated plugin PRs that are following our standard, documented process.
@stuartmorgan-g stuartmorgan-g mentioned this pull request Aug 25, 2025
Merged
@stuartmorgan-g stuartmorgan-g added the federated: all_changes PR that contains changes for all packages for a federated plugin change label Aug 25, 2025
@camsim99 camsim99 changed the title [camera] Fix issue 148013: setDescriptionWhileRecording with android camerax [camera_android_camerax] Implement setDescriptionWhileRecording Aug 25, 2025
camsim99
camsim99 reviewed Aug 25, 2025
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution! I'm looking forward to having this feature implemented :)

Took a first pass (at the camera_android_camerax code because the rest can be reverted). Overall looks good, but I think the main changes need a few adjustments.

auto-submit bot pushed a commit that referenced this pull request Aug 26, 2025
@stuartmorgan-g
Try to convince GCA to stop complaining about dependency_overrides (#…
3dae1f6 
…9879)

Adds a section to the review agent configuration to try to get it to stop leaving comments like [this one](#9878 (comment)) on federated plugin PRs that are following our standard, documented process.
@blackorbs-dev
Copy link
Author

I need help on the failing checks @stuartmorgan-g @camsim99. For the repo_checks, I'm having issue with format and federated safety check. I believe the federated check will be fixed when the dependencies overrides are reverted but the format is throwing error:

Formatting .kt files... 
Running command: "java -jar /b/s/w/ir/x/w/packages/script/tool/bin/ktfmt-0.46-jar-with-dependencies.jar camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/CameraXLibrary.g.kt camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/ResultCompat.kt" in /b/s/w/ir/x/w/packages/packages 
Error: Invalid or corrupt jarfile /b/s/w/ir/x/w/packages/script/tool/bin/ktfmt-0.46-jar-with-dependencies.jar 
Failed to format Kotlin files: exit code 1.

Even though there are no issues when I ran it locally:

Formatting .kt files...
Running command: "java -jar /Users/blackorbs/AndroidStudioProjects/packages/script/tool/bin/ktfmt-0.46-jar-with-dependencies.jar camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/CameraXLibrary.g.kt camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/ResultCompat.kt" in /Users/blackorbs/AndroidStudioProjects/packages/packages
Done formatting camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/ResultCompat.kt
Done formatting camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/CameraXLibrary.g.kt

Also, I can't figure out why the tree-status check failed for the last commit.

@camsim99
Copy link
Contributor

@blackorbs-dev Agreed on the federated check, for format, I see the error Error: Invalid or corrupt jarfile /b/s/w/ir/x/w/packages/script/tool/bin/ktfmt-0.46-jar-with-dependencies.jar. Not quite sure what that's about but that's the issue there. My gut is just to re-run it or make sure this branch is up to date with main. I can help debug further if it doesn't go away.

Also, thanks for making edits! I'll take a look soon.

@camsim99
Copy link
Contributor

camsim99 commented Aug 27, 2025 •
edited
Loading

By the way, this PR can also remove this line: https://github.com/flutter/packages/blob/main/packages/camera/camera_android_camerax/README.md#setdescriptionwhilerecording-is-unimplemented-issue-148013 🥳

@blackorbs-dev
Copy link
Author

By the way, this PR can also remove this line: https://github.com/flutter/packages/blob/main/packages/camera/camera_android_camerax/README.md#setdescriptionwhilerecording-is-unimplemented-issue-148013 🥳

Noted ✅, I can also revert the dependency overrides right?

@stuartmorgan-g
Copy link
Collaborator

I see the error Error: Invalid or corrupt jarfile /b/s/w/ir/x/w/packages/script/tool/bin/ktfmt-0.46-jar-with-dependencies.jar. Not quite sure what that's about but that's the issue there.

I would guess network or server error downloading the formatter, since it's pulled on demand rather than via cipd.

@blackorbs-dev
Copy link
Author

I've made edits based on your comments @stuartmorgan-g @camsim99. Please take a look.

@blackorbs-dev

This comment was marked as duplicate.

Sign in to view
camsim99
camsim99 reviewed Sep 2, 2025
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me! Just left some nits.

@stuartmorgan-g
Copy link
Collaborator

@bparrishMines is the ecosystem team reviewer for camera; my comments were just drive-by from triaging PRs.

@camsim99 camsim99 self-requested a review September 8, 2025 15:30
camsim99
camsim99 approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The camera_android_camerax changes LGTM! Thank you so much for taking this on!! Just left a nit about the README.

Just need another review from @bparrishMines.

bparrishMines
bparrishMines reviewed Sep 10, 2025
View reviewed changes
bparrishMines
bparrishMines approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This should be ready to split out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g left review comments

@bparrishMines bparrishMines bparrishMines approved these changes

@camsim99 camsim99 camsim99 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
federated: all_changes PR that contains changes for all packages for a federated plugin change p: camera platform-android triage-android Should be looked at in Android triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[camera_android_camerax] Implement setDescriptionWhileRecording
4 participants
@blackorbs-dev @stuartmorgan-g @camsim99 @bparrishMines