Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

stuartmorgan-g
Copy link
Collaborator

Updates CODEOWNERS for web plugins to reflect team changes.

Updates CODEOWNERS for web plugins to reflect team changes.
@stuartmorgan-g
Copy link
Collaborator Author

@mdebbar Please let me know if you want to shard any of these out to specific team members instead, the way we do with the other platform verticals.

@ditman If you still want to actively own any of these, please let me know!

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CODEOWNERS file to reflect team changes. Ownership of several web-related packages and web-specific implementations is transferred from @ditman to @mdebbar. Additionally, ownership of packages/cross_file/** and packages/extension_google_sign_in_as_googleapis_auth/** is transferred from @ditman to @stuartmorgan. The changes appear correct, though I have noted one potential omission for another web package that you may want to address.

packages/file_selector/** @stuartmorgan-g
packages/flutter_lints/** @chunhtai
packages/flutter_template_images/** @stuartmorgan-g
packages/go_router/** @chunhtai
packages/go_router_builder/** @chunhtai
packages/google_adsense/** @sokoloff06 @ditman
packages/google_identity_services_web/** @ditman
packages/google_identity_services_web/** @mdebbar

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While updating the owner for this web package, it seems another web package may have been missed. For consistency with the other changes in this PR, consider also updating the owner for google_adsense on line 16 from @ditman to @mdebbar, as it also appears to be a web package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant