Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/plugins
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 26c45dc
Choose a base ref
...
head repository: flutter/plugins
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fcbb0ce
Choose a head ref
  • 6 commits
  • 77 files changed
  • 3 contributors

Commits on May 10, 2021

  1. Fix the description (#3869)

    @ydag
    ydag authored May 10, 2021
    Configuration menu
    Copy the full SHA
    6f8bb67 View commit details
    Browse the repository at this point in the history

  2. Check in macOS example Podfiles (#3864) 

    PR #3747 stopped ignoring Podfiles and added the missing iOS Podfiles,
but not the macOS Podfiles.
    @stuartmorgan-g
    stuartmorgan-g authored May 10, 2021
    Configuration menu
    Copy the full SHA
    7765fa0 View commit details
    Browse the repository at this point in the history

  3. Simplify the tooling bash scripts (#3865) 

    - Rename incremental_build.sh to tool_runner.sh since it has been used for things other than building for a while, and also isn't always incremental.
- Replace check_publish.sh with tool_runner.sh to reduce the number of special-case scripts. This is a small behavioral change in that now PRs that don't change any packages will test all packages, as with our other scripts.
- Eliminate check_changed_packages. All critical uses have now been replaced by the Dart version of the logic, and the one remaining use was purely for an error message that says something that should be relatively easy to figure out from context anyway.

This means we have less bash code to maintain (without unit tests) and understand.
    @stuartmorgan-g
    stuartmorgan-g authored May 10, 2021
    Configuration menu
    Copy the full SHA
    0c99a3b View commit details
    Browse the repository at this point in the history

  4. Ensure that integration tests are actually being run (#3857) 

    Many of our integration tests weren't actually being run on CI because they were in the wrong place and/or missing the driver file, and it seems we've just never noticed. This makes a number of changes:
- Ensures that all packages with integration tests also have a driver file in the right location.
  - Also standardizes the format of those files, as the boilerplate `main()` is available in `integration_test`.
- Ensures that all integration_test directories are in the right place.
  - In a couple of places, removes a duplicate copy of the integration test file.
- Makes it an error for a plugin that's not excluded to not have integration tests, so this can't easily happen again.
- Adds logging of what's being run and skipped, so if something does go wrong in the future it's easy to determine what from the logs.
  - Excludes `*_platform_interface` since the logging was (potentially confusingly) reporting that they were skipped because they don't support the current platform. Skipping them is correct, just not for that reason.
- Excludes the plugins that currently have no integration tests, with references to issues about adding them.

Fixes flutter/flutter#81929
    @stuartmorgan-g
    stuartmorgan-g authored May 10, 2021
    Configuration menu
    Copy the full SHA
    37ac97f View commit details
    Browse the repository at this point in the history

  5. Exclude some missing integration tests (#3872) 

    ios_platform_images does not currently have an integration test, and file_chooser does not have a web integration test, so both must be explicitly excluded due to recent tooling changes.

See:
flutter/flutter#82208
flutter/flutter#82211
    @stuartmorgan-g
    stuartmorgan-g authored May 10, 2021
    Configuration menu
    Copy the full SHA
    0474ef8 View commit details
    Browse the repository at this point in the history

  6. [google_sign_in] fix registration links (#3859) 

    Fixes flutter/flutter#81847
    @kevmoo
    kevmoo authored May 10, 2021
    Configuration menu
    Copy the full SHA
    fcbb0ce View commit details
    Browse the repository at this point in the history
Loading