Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Update iOS platform target #2753

Closed
wants to merge 4 commits into from
Closed

[camera] Update iOS platform target #2753

wants to merge 4 commits into from

Conversation

devtronic
Copy link

Description

Since the camera package uses the AVCaptureDeviceDiscoverySession class, the minimum iOS SDK must be 10.0 (https://developer.apple.com/documentation/avfoundation/avcapturedevicediscoverysession)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide). Not relevant
  • All existing and new tests are passing. Not relevant
  • I updated/added relevant documentation (doc comments with ///). Not relevant
  • The analyzer (flutter analyze) does not report any problems on my PR. Not relevant
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@devtronic devtronic requested a review from bparrishMines as a code owner May 12, 2020 21:52
@devtronic devtronic changed the title [camera] Update camera.podspec [camera] Update iOS platform target May 12, 2020
@devtronic
Copy link
Author

What's wrong with the checks?

@bparrishMines
Copy link
Contributor

@devtronic It looks like the iOS tests are failing because the camera example app is supporting versions 8.0+ and this changes the minimum version to 10.0.

I don't think we want to go with this change because there could be a scenario where someone wants to compile for iOS 8.0+, but provides the camera feature only for devices that are 10.0+.

We may want to go with another solution like updating the README of the 10.0+ requirements.

@danielroek danielroek mentioned this pull request Dec 16, 2020
12 tasks
@mvanbeusekom
Copy link
Contributor

Closing in favour of #3335

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants