Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Added null pointer check to prevent camera plugin from crashing #2769

Closed
wants to merge 2 commits into from
Closed

[camera] Added null pointer check to prevent camera plugin from crashing #2769

wants to merge 2 commits into from

Conversation

dirjud
Copy link

@dirjud dirjud commented May 18, 2020

Description

This fixes the camera app from referencing a null pointer and causing my flutter app to crash.

Related Issues

flutter/flutter#19595

Checklist

  • [x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [ x] All existing and new tests are passing.
  • [ x] I updated/added relevant documentation (doc comments with ///).
  • [ x] The analyzer (flutter analyze) does not report any problems on my PR.
  • [x ] I read and followed the Flutter Style Guide.
  • [ x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • [x ] I updated CHANGELOG.md to add a description of the change.
  • [x ] I signed the CLA.
  • [x ] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mvanbeusekom
Copy link
Contributor

Closing this PR in favour of #3127 (which is merged and published with version 0.5.8+11 of the camera plugin).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirjud @googlebot @mvanbeusekom