Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[wifi_info_flutter_platform_interface] Ready to publish #3190

Merged
merged 3 commits into from
Oct 22, 2020
Merged

[wifi_info_flutter_platform_interface] Ready to publish #3190

merged 3 commits into from
Oct 22, 2020

Conversation

cyanglaz
Copy link
Contributor

Make the plugins ready to be published

@google-cla google-cla bot added the cla: yes label Oct 22, 2020
@amirh
Copy link
Contributor

amirh commented Oct 22, 2020

Please make sure to wait for @bparrishMines's approval before landing.

@slightfoot
Copy link
Member

@amirh we have been looking at splitting the connectivity_plus plugin up into network_info_plus to address the current permissions problem. Happy to take this PR over in the plus repo. Let me know. /cc @mhadaily

bparrishMines
bparrishMines reviewed Oct 22, 2020
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the pubspec.yaml, we should change

wifi_info_flutter_platform_interface:
    path: ../wifi_info_flutter_platform_interface

to

wifi_info_flutter_platform_interface: 1.0.0

It will cause the PR to fail until it is published though.

@cyanglaz
Copy link
Contributor Author

@bparrishMines How about we only land the platform interface change in the PR, publish interface, then land another PR for the plugin change.

@cyanglaz cyanglaz changed the title [wifi_info_flutter] Ready to publish [wifi_info_flutter_platform_interface] Ready to publish Oct 22, 2020
bparrishMines
bparrishMines approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyanglaz That plan works for me.

LGTM

@cyanglaz
Copy link
Contributor Author

Im going to land on red as the failure are about not updating the version. This PR didn't update the version because the last version wasn't published.

@cyanglaz
Copy link
Contributor Author

@bparrishMines actually, it looks like the version in CHANGELOG.MD and pubspec didn't match. I fixed it, could you take another look?

bparrishMines
bparrishMines approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit 87ea6da into flutter:master Oct 22, 2020
@cyanglaz cyanglaz deleted the wifi_info_flutter_ready_to_publish branch October 22, 2020 21:27
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
[wifi_info_flutter_platform_interface] Ready to publish (flutter#3190)
d7a1a73
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bparrishMines bparrishMines bparrishMines approved these changes

@amirh amirh Awaiting requested review from amirh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyanglaz @amirh @slightfoot @bparrishMines