This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Remove unused test dependencies add missing environment constraints
#3239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
October 28, 2020 10:56
test dependenciestest dependencies add missing environment constraints
added 2 commits
November 2, 2020 09:17
|
I'm going to see if this fixes the hang issue for the plugins in this PR, if so, i'll merge #3240 into this. |
|
Looks like the timeout is fixed by this. Merged 3240 and re-running CI. |
|
CC @zanderso For the 3240 merging. |
|
Also merged #3219 so we can remove the |
|
If this passes CI and gets the tree open I'm fine with that. We really should figure out what's going on with vm_service that's causing things to hang sometimes. |
|
Failure is due to https://github.com/flutter/plugin_tools/pull/119 |
fesp
pushed a commit
to fesp/plugins
that referenced
this pull request
Nov 11, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
testdependency seems to cause CI to hang, and we are not using them mostly in this repo so we can remove those and make the tree green. This PR only unblocks the tree, it didn't fix the root cause of the issue. See discussion in the issue for details.This PR also adds env constraints for some example apps who are missing env constraints.
Related Issues
flutter/flutter#69439
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?