Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[file_selector] add GtkFileChooserDialog based implementation for Linux #3257

Closed
wants to merge 1 commit into from
Closed

[file_selector] add GtkFileChooserDialog based implementation for Linux #3257

wants to merge 1 commit into from

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Nov 8, 2020 •
edited
Loading

Description

This PR implements the FileSelector method channel interface for Linux. The implementation is based on GtkFileChooserDialog from GTK+ and has been tested with the example app in https://github.com/tugorez/plugins/tree/file_selector/packages/file_selector/file_selector/example

Related PRs

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jpnurmi jpnurmi requested a review from ditman as a code owner November 8, 2020 16:03
@google-cla google-cla bot added the cla: yes label Nov 8, 2020
@jpnurmi
[file_selector] add GtkFileChooserDialog based implementation for Linux
085d6d5 
file_selector_linux needs to be endorsed in the app-facing file_selector
package when done.
@jpnurmi
Copy link
Member Author

jpnurmi commented Nov 9, 2020 •
edited
Loading

I ran clang-format -i --style=Google file_selector_linux_plugin.cc to fix the format check.

@jpnurmi
Copy link
Member Author

jpnurmi commented Nov 9, 2020

/cc @tugorez @jasonpanelli

@ditman
Copy link
Member

ditman commented Nov 9, 2020

Thanks for the contribution! I'm totally unqualified to review linux code for now; @stuartmorgan is the boss here!

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Nov 9, 2020 •
edited
Loading

@robert-ancell would be the best person to do the initial review here.

However, I'm confused why this was written from scratch when we already have the FDE file_chooser plugin; my plan was to simply convert that over to the new plugin's API (and in fact, I have that mostly done for macOS and Windows). Did you have an issue with that code?

@jpnurmi
Copy link
Member Author

jpnurmi commented Nov 9, 2020

I see. I was simply not aware of the other implementation.

@jpnurmi
Copy link
Member Author

jpnurmi commented Nov 9, 2020

No reason to spend time reviewing this since an implementation already exists.

@jpnurmi jpnurmi closed this Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman Awaiting requested review from ditman

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpnurmi @ditman @stuartmorgan-g