Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[connectivity] Clear networkCallback object as soon as stream is cancelled #3303

Merged
merged 22 commits into from
Dec 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b1c0e17
Reland: [e2e] Replaces the check for ActivityTestRule (#2633)
ened Apr 17, 2020
7670c96
Merge branch 'master' of github.com:ened/plugins
ened May 23, 2020
aeb0a3a
Merge branch 'master' of https://github.com/flutter/plugins
ened May 23, 2020
a93b935
Merge branch 'master' of github.com:ened/plugins
May 28, 2020
ac8de30
Merge branch 'master' of https://github.com/flutter/plugins
ened Jun 6, 2020
8a07d76
Merge branch 'master' of https://github.com/flutter/plugins
ened Jun 8, 2020
bcf05d1
Merge branch 'master' of https://github.com/flutter/plugins
Jul 9, 2020
38f5cfe
Merge branch 'master' of https://github.com/flutter/plugins
Jul 14, 2020
d4badb0
Merge branch 'master' of https://github.com/flutter/plugins
Jul 16, 2020
ff51d61
Merge branch 'master' of https://github.com/flutter/plugins
Jul 27, 2020
26930f8
Merge branch 'master' of https://github.com/flutter/plugins
Aug 28, 2020
5a8f350
Merge branch 'master' of https://github.com/flutter/plugins
Sep 2, 2020
9873b3c
Merge branch 'master' of github.com:ened/plugins into master
ened Sep 9, 2020
60c4a5f
Merge branch 'master' of https://github.com/flutter/plugins into master
ened Sep 9, 2020
e48fe36
Merge branch 'master' of https://github.com/flutter/plugins into master
Oct 23, 2020
4b4cfd4
Merge branch 'master' of github.com:ened/plugins into master
Oct 23, 2020
13cde73
Merge branch 'master' of https://github.com/flutter/plugins into master
Nov 5, 2020
e709bed
Merge branch 'master' of https://github.com/flutter/plugins
ened Dec 4, 2020
c8d95d2
Set networkCallback back to null when event stream is cancelled
ened Dec 4, 2020
f98888e
Bump version, add changelog
ened Dec 4, 2020
e60cbf4
Merge branch 'master' of https://github.com/flutter/plugins
Dec 18, 2020
020ac01
Merge branch 'master' into connectivity-cleanup
Dec 18, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/connectivity/connectivity/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 3.0.0-nullsafety.2

* Android: Cleanup the NetworkCallback object when a connectivity stream is cancelled

## 3.0.0-nullsafety.1

* Bump Dart SDK to support null safety.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public void onCancel(Object arguments) {
if (android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
if (networkCallback != null) {
connectivity.getConnectivityManager().unregisterNetworkCallback(networkCallback);
networkCallback = null;
}
} else {
context.unregisterReceiver(this);
Expand Down
2 changes: 1 addition & 1 deletion packages/connectivity/connectivity/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: connectivity
description: Flutter plugin for discovering the state of the network (WiFi &
mobile/cellular) connectivity on Android and iOS.
homepage: https://github.com/flutter/plugins/tree/master/packages/connectivity/connectivity
version: 3.0.0-nullsafety.1
version: 3.0.0-nullsafety.2

flutter:
plugin:
Expand Down