Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

added disclaimer for missing web support in readme of url_launcher. #3350

Closed

Conversation

Roshan13046
Copy link

Description

Added disclaimer for missing web support in the readme file of url_launcher: 6.0.0-nullsafety.1.

Related Issues

Fixes #72239

##Tests

I added the following tests: N/A because only docs are changed.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@Roshan13046 Roshan13046 requested a review from mklim as a code owner December 18, 2020 10:10
@google-cla google-cla bot added the cla: yes label Dec 18, 2020

## Disclaimer
The `url_launcher: 6.0.0-nullsafety.1` plugin is missing web support.
The web suppport is temporary disabled until web is migrated to nnbd.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: support* and temporarily*

@Roshan13046
Copy link
Author

Please check my PR.

@stuartmorgan-g
Copy link
Contributor

Thanks for the submission. However, since #3436 documented this in the release notes since this PR was created, and support for web (along with re-endorsement) is now actively under development, I think the current state is sufficient for a temporary prerelease limitation, rather than go through the process of yet another minor release to adjust the documentation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants