Move all null safety packages' min dart sdk to 2.12.0 #3822

cyanglaz · 2021-04-22T19:01:18Z

This is mainly to remove the warning when pub publish. We can skip publishing this change for now.

stuartmorgan-g

Looks good, but can you also update the publish check script to no longer allow this warning to pass?

ditman · 2021-04-22T19:48:23Z

Ssssso many packages! :P

cyanglaz · 2021-04-22T22:57:40Z

Looks good, but can you also update the publish check script to no longer allow this warning to pass?

Good point! done!

stuartmorgan-g · 2021-04-22T23:10:07Z

Needs test updates for the tool behavioral change :)

This reverts commit 1c75efc.

cyanglaz · 2021-04-23T03:22:35Z

I think maybe we can add a flag to keep the feature that ignores pre-release check, for possible feature release requirement. I did it in the PR. let me know if you think otherwise and if so why. @stuartmorgan @ditman

stuartmorgan-g

Keeping it behind a flag SGTM.

stuartmorgan-g · 2021-04-23T15:16:38Z

script/tool/lib/src/publish_check_command.dart

+    argParser.addFlag(
+      _allowPrereleaseFlag,
+      help: 'Allows the pre-release SDK warning to pass.'
+          'When enabled, a pub warning, which asks to publish the package as a pre-release version when'


You're missing spaces at the ends of these string literals, so they won't concatenate correctly.

Added a new line after the first sentence.

The second part still has the same problem; this will print "[...] a pre-release verison whenthe SDK [...]"

stuartmorgan-g · 2021-04-23T15:17:45Z

script/tool/test/publish_check_command_test.dart

@@ -90,7 +90,7 @@ void main() {
          throwsA(isA<ToolExit>()));
    });

-    test('pass on prerelease', () async {
+    test('pass on prerelease is --allow-pre-release flag is on', () async {


Nit: s/is/if/

stuartmorgan-g · 2021-04-23T15:18:23Z

script/tool/test/publish_check_command_test.dart

@@ -105,7 +105,8 @@ void main() {

      processRunner.processesToReturn.add(process);

-      expect(runner.run(<String>['publish-check']), completes);
+      expect(runner.run(<String>['publish-check', '--allow-pre-release']),
+          completes);
    });


We also need a new test that the same setup fails without --allow-pre-release

cyanglaz

@stuartmorgan Fixed

cyanglaz · 2021-04-23T15:58:07Z

script/tool/lib/src/publish_check_command.dart

+    argParser.addFlag(
+      _allowPrereleaseFlag,
+      help: 'Allows the pre-release SDK warning to pass.'
+          'When enabled, a pub warning, which asks to publish the package as a pre-release version when'


Added a new line after the first sentence.

cyanglaz · 2021-04-23T16:00:36Z

script/tool/test/publish_check_command_test.dart

@@ -105,7 +105,8 @@ void main() {

      processRunner.processesToReturn.add(process);

-      expect(runner.run(<String>['publish-check']), completes);
+      expect(runner.run(<String>['publish-check', '--allow-pre-release']),
+          completes);
    });


cyanglaz · 2021-04-23T16:00:39Z

script/tool/test/publish_check_command_test.dart

@@ -90,7 +90,7 @@ void main() {
          throwsA(isA<ToolExit>()));
    });

-    test('pass on prerelease', () async {
+    test('pass on prerelease is --allow-pre-release flag is on', () async {


stuartmorgan-g

LGTM with nit

stuartmorgan-g · 2021-04-23T16:12:20Z

script/tool/lib/src/publish_check_command.dart

+    argParser.addFlag(
+      _allowPrereleaseFlag,
+      help: 'Allows the pre-release SDK warning to pass.'
+          'When enabled, a pub warning, which asks to publish the package as a pre-release version when'


The second part still has the same problem; this will print "[...] a pre-release verison whenthe SDK [...]"

…r/plugins#3822)

…r/plugins#3822) (#81061)

* master: (79 commits) Fix grammatical error in contributing guide (flutter#3217) [google_sign_in_web] fix README typos. [tool] combine run and runAndExitOnError (flutter#3827) [camera] android-rework part 2: Android auto focus feature (flutter#3796) [in_app_purchase_platform_interface] Added additional fields to ProductDetails (flutter#3826) Move all null safety packages' min dart sdk to 2.12.0 (flutter#3822) [path_provider_*] code cleanup: sort directives (flutter#3823) [in_app_purchase] Implementation of platform interface (flutter#3781) [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter#3819) [tools] fix version check command not working for new packages (flutter#3818) [camera] android-rework part 1: Base classes to support Android Camera features (flutter#3795) fix MD (flutter#3815) Path provider windows crash fix (flutter#3814) [local_auth] docs update (flutter#3103) Update PULL_REQUEST_TEMPLATE.md (flutter#3801) [quick_actions] handle cold start on iOS correctly (flutter#3811) Replace path_provider_linux widget tests with simple unit tests (flutter#3812) [sensors] format dart code based on the new dart formatter (flutter#3809) [google_sign_in] Fix "pick account" on iOS (flutter#3805) [image_picker_platform_interface] Added pickMultiImage (flutter#3782) ...

* upstream/master: (383 commits) Add implement and registerWith method to plugins (flutter#3833) Update third_party license checking (flutter#3844) [tool] add `all` and `dry-run` flags to publish-plugin command (flutter#3776) Re-add bin/ to flutter_plugin_tools (flutter#3839) switch from using 'tuneup' to analyze to 'dart analyze' (flutter#3837) [in_app_purchase] Federated iOS implementation (flutter#3832) Prep the tools for publishing (flutter#3836) [in_app_purchase] Make PurchaseDetails.status mandatory (flutter#3831) Fix grammatical error in contributing guide (flutter#3217) [google_sign_in_web] fix README typos. [tool] combine run and runAndExitOnError (flutter#3827) [camera] android-rework part 2: Android auto focus feature (flutter#3796) [in_app_purchase_platform_interface] Added additional fields to ProductDetails (flutter#3826) Move all null safety packages' min dart sdk to 2.12.0 (flutter#3822) [path_provider_*] code cleanup: sort directives (flutter#3823) [in_app_purchase] Implementation of platform interface (flutter#3781) [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter#3819) [tools] fix version check command not working for new packages (flutter#3818) [camera] android-rework part 1: Base classes to support Android Camera features (flutter#3795) fix MD (flutter#3815) ...

Chris Yang added 2 commits April 22, 2021 11:59

move min dart to 2.12 for null safety packages

94948fb

more

093d85b

cyanglaz requested review from bparrishMines, ditman, gaaclarke and LHLL as code owners April 22, 2021 19:01

google-cla bot added the cla: yes label Apr 22, 2021

stuartmorgan-g reviewed Apr 22, 2021

View reviewed changes

remove allowing warnings in publish check

1c75efc

Chris Yang added 4 commits April 22, 2021 20:04

remove presubmit test

8f0ac72

fix test, move remaining packages to 2.12.0

31e98bf

Revert "remove allowing warnings in publish check"

87c5b54

This reverts commit 1c75efc.

add flag to allow pre-release

db8fb5d

github-actions bot added p: android_alarm_manager p: google_maps_flutter labels Apr 23, 2021

cyanglaz removed request for LHLL and gaaclarke April 23, 2021 03:23

stuartmorgan-g suggested changes Apr 23, 2021

View reviewed changes

review

4da8e0a

cyanglaz commented Apr 23, 2021

View reviewed changes

cyanglaz requested a review from stuartmorgan-g April 23, 2021 16:00

stuartmorgan-g approved these changes Apr 23, 2021

View reviewed changes

fix help message

adfb3b3

cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 23, 2021

fluttergithubbot merged commit 50f9ee9 into flutter:master Apr 23, 2021

github-actions bot added the needs-publishing label Apr 23, 2021

engine-flutter-autoroll mentioned this pull request Apr 23, 2021

Roll Plugins from 015a77290c85 to 50f9ee978900 (1 revision) flutter/flutter#81061

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 23, 2021

50f9ee9 Move all null safety packages' min dart sdk to 2.12.0 (flutte…

0fa7d96

…r/plugins#3822)

fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Apr 23, 2021

50f9ee9 Move all null safety packages' min dart sdk to 2.12.0 (flutte…

57ab4c9

…r/plugins#3822) (#81061)

stuartmorgan-g removed the needs-publishing label Apr 27, 2021

fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021

Move all null safety packages' min dart sdk to 2.12.0 (flutter#3822)

daa3790

Move all null safety packages' min dart sdk to 2.12.0 #3822

Move all null safety packages' min dart sdk to 2.12.0 #3822

Uh oh!

Conversation

cyanglaz commented Apr 22, 2021

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

ditman commented Apr 22, 2021

Uh oh!

cyanglaz commented Apr 22, 2021

Uh oh!

stuartmorgan-g commented Apr 22, 2021

Uh oh!

cyanglaz commented Apr 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cyanglaz commented Apr 23, 2021 •

edited

Loading