Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[share] Do not tear down channel onDetachedFromActivity. #3942

Merged
merged 5 commits into from
May 21, 2021
Merged

[share] Do not tear down channel onDetachedFromActivity. #3942

merged 5 commits into from
May 21, 2021

Conversation

zhenqiu1101
Copy link
Contributor

@zhenqiu1101 zhenqiu1101 commented May 20, 2021 •
edited
Loading

We should not tear down the method channel onDetachedFromActivity. That will cause MissingPluginException for the following method calls. internal: b/183065251. Open source issue: flutter/flutter#12264

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label May 20, 2021
@zhenqiu1101
Copy link
Contributor Author

Open source issue: flutter/flutter#12264

@zhenqiu1101 zhenqiu1101 requested review from cyanglaz and xster May 20, 2021 04:33
@xster
Copy link
Member

xster commented May 20, 2021

This is sooooo good! Awesome find! This totally makes sense. The current implementation doesn't work since it's not symmetrical between engine attach/detach and activity attach/detach.

@zhenqiu1101
Copy link
Contributor Author

@cyanglaz

Hi Chris, could you advice on the test failures?

@zhenqiu1101
Copy link
Contributor Author

Chris is on leave. @stuartmorgan could you please advice on the test failures? It looks unrelated the PR. iOS share test and url_launcher plugin. Wanna make sure that the PR is safe to merge. Thanks!

@zhenqiu1101
Merge remote-tracking branch 'upstream/master'
90b47b0 
Try merging to fix the tests.
@stuartmorgan-g
Copy link
Contributor

We can land this since it's affecting an internal customer, but we're in the process of turning this plugin down in favor of https://pub.dev/packages/share_plus; see the notice in CONTRIBUTING.md. You should submit this fix there as well since at some point there should be a transition to that version, and you'll want to have this fix there as well.

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 21, 2021
@zhenqiu1101 zhenqiu1101 merged commit 9b1f9ee into flutter:master May 21, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2021
@engine-flutter-autoroll
9b1f9ee [share] Do not tear down channel onDetachedFromActivity. (flu…
6fe0174 
…tter/plugins#3942)
@zhenqiu1101 zhenqiu1101 mentioned this pull request May 21, 2021
Merged
9 tasks
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request May 21, 2021
@engine-flutter-autoroll
9b1f9ee [share] Do not tear down channel onDetachedFromActivity. (flu…
a9b9802 
…tter/plugins#3942) (#83120)
@stuartmorgan-g stuartmorgan-g mentioned this pull request May 27, 2021
Closed
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@zhenqiu1101 @fotiDim
[share] Do not tear down channel onDetachedFromActivity. (flutter#3942)
e4bb183 
* Remove the tearDownChannel onDetachedFromActivity. Only set activity to null.

* update changelog

* increase version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xster xster xster approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

Assignees
No one assigned
Labels
cla: yes p: share platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhenqiu1101 @xster @stuartmorgan-g