Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase]IAP/platform interface add cancel status #4093

Merged
merged 6 commits into from
Oct 29, 2021
Merged

[in_app_purchase]IAP/platform interface add cancel status #4093

merged 6 commits into from
Oct 29, 2021

Conversation

ydag
Copy link
Contributor

@ydag ydag commented Jun 24, 2021 •
edited
Loading

This PR adds a new PurchaseStatus named canceled to distinguish between an error and user cancellation.

Related issues:

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ydag ydag requested review from cyanglaz and LHLL as code owners June 24, 2021 12:09
@google-cla google-cla bot added the cla: yes label Jun 24, 2021
This was referenced Jun 24, 2021
Merged
Merged
mvanbeusekom
mvanbeusekom approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mvanbeusekom
mvanbeusekom suggested changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved a bit too fast. It would actually be good to add unit-tests that will verify the amount of elements in the enum and check that their index is correct.

Here are two examples:

@ydag ydag requested a review from mvanbeusekom July 7, 2021 10:08
mvanbeusekom
mvanbeusekom approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs a rebase to resolve conflicts but can be merged afterwards

@ydag
Merge branch 'master' into iap/platform_interface_add_cancel_status
2f3142a 
# Conflicts:
#	packages/in_app_purchase/in_app_purchase_platform_interface/CHANGELOG.md
#	packages/in_app_purchase/in_app_purchase_platform_interface/pubspec.yaml
@ydag
Merge branch 'master' into iap/platform_interface_add_cancel_status
9d5d071 
# Conflicts:
#	packages/in_app_purchase/in_app_purchase_platform_interface/CHANGELOG.md
#	packages/in_app_purchase/in_app_purchase_platform_interface/pubspec.yaml
@Hixie Hixie changed the title [in_app_purchase]Iap/platform interface add cancel status [in_app_purchase]IAP/platform interface add cancel status Oct 26, 2021
@Hixie
Copy link
Contributor

Hixie commented Oct 26, 2021

What's the status of this PR?

cyanglaz
cyanglaz approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz
Copy link
Contributor

@ydag Maybe rebase master to fix CI?

@cyanglaz cyanglaz added waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for test harness labels Oct 27, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Oct 27, 2021
@mvanbeusekom
Copy link
Contributor

@cyanglaz and @ydag, I will take care of this. As @ydag has internally been put on other projects.

@google-cla
Copy link

google-cla bot commented Oct 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 29, 2021
@mvanbeusekom
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 29, 2021
@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Oct 29, 2021
@fluttergithubbot fluttergithubbot merged commit e51cc1d into flutter:master Oct 29, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2021
@engine-flutter-autoroll
e51cc1d [in_app_purchase]IAP/platform interface add cancel status (fl…
23bd5e5 
…utter/plugins#4093)
NickalasB added a commit to NickalasB/plugins that referenced this pull request Nov 4, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
e17df4c 
* master:
  [webview_flutter] Deprecate evaluateJavascript in favour of runJavaScript and runJavaScriptForResult. (flutter#4403)
  [webview_flutter] Add interface methods to load local files and HTML strings. (flutter#4446)
  [ci] add pedantic dep to new in_app_purchase pkgs (flutter#4471)
  [ci] Remove unused dep from file_selector. (flutter#4468)
  [ci] update build_runner dep in android_intent and file_selector example (flutter#4467)
  [webview_flutter] Add platform interface method `loadRequest`. (flutter#4450)
  Remove -Werror from deprecated plugin Android builds (flutter#4466)
  [webview_flutter] Update webview packages for Android and iOS to implement `runJavascript` and `runJavascriptReturningResult`. (flutter#4402)
  [camera] Fix CamcorderProfile Usages (flutter#4423)
  [google_sign_in] Use a transparent image as a placeholder for the `GoogleUserCircleAvatar` (flutter#4391)
  [in_app_purchase]IAP/platform interface add cancel status (flutter#4093)
  [image_picker] doc:readme image picker misprints (flutter#4421)
  Support Hybrid Composition through the GoogleMaps Widget (flutter#4082)
  [path_provider] started supporting background platform channels (flutter#4443)
  [device_info] started using Background Platform Channels (flutter#4456)

# Conflicts:
#	packages/webview_flutter/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/webview_flutter/pubspec.yaml
@mvanbeusekom mvanbeusekom deleted the iap/platform_interface_add_cancel_status branch November 17, 2021 10:59
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@ydag @amantoux
[in_app_purchase]IAP/platform interface add cancel status (flutter#4093)
ee3f1b9
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@ydag @KyleFin
[in_app_purchase]IAP/platform interface add cancel status (flutter#4093)
52a74fa
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@LHLL LHLL Awaiting requested review from LHLL

Assignees
No one assigned
Labels
cla: yes p: in_app_purchase waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ydag @Hixie @cyanglaz @fluttergithubbot @mvanbeusekom