This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[in_app_purchase]Iap/ios add cancel status #4094
Merged
fluttergithubbot
merged 11 commits into
flutter:master
from
Baseflow:iap/ios_add_cancel_status
Nov 17, 2021
Merged
[in_app_purchase]Iap/ios add cancel status #4094
fluttergithubbot
merged 11 commits into
flutter:master
from
Baseflow:iap/ios_add_cancel_status
Nov 17, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
mvanbeusekom
suggested changes
Jul 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly request to add some clarification on error codes and small nit in format of unit-tests.
packages/in_app_purchase/in_app_purchase_ios/lib/src/store_kit_wrappers/enum_converters.dart
Show resolved
Hide resolved
packages/in_app_purchase/in_app_purchase_ios/test/in_app_purchase_ios_platform_test.dart
Show resolved
Hide resolved
packages/in_app_purchase/in_app_purchase_ios/test/in_app_purchase_ios_platform_test.dart
Show resolved
Hide resolved
#4093 has now landed, does that mean this PR is now ready to be worked on again? |
mvanbeusekom
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2021
11 tasks
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
p: in_app_purchase
platform-ios
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a breaking change to handle the new
PurchaseStatus
namedcanceled
. This means developers can distinguish between an error and user cancellation.Before merging this PR following PR has to be merged :
Related issues:
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.