Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Update to ExoPlayer 2.14.1#4141

Merged
stuartmorgan-g merged 5 commits intoflutter:masterfrom
stuartmorgan-g:video-player-exoplayer-2-14
Jul 7, 2021
Merged

[video_player] Update to ExoPlayer 2.14.1#4141
stuartmorgan-g merged 5 commits intoflutter:masterfrom
stuartmorgan-g:video-player-exoplayer-2-14

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Jul 7, 2021 •
edited
Loading

Update the ExoPlayer dependency to the latest version, and remove the dependency on the deprecated Bintray server. This should resolve issues with building video_player due to 403s from bintray that have been breaking presubmits for all PRs.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla
Copy link

google-cla bot commented Jul 7, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 7, 2021
@stuartmorgan-g stuartmorgan-g changed the title [video_player] Update to exoplayer 2.14.1 [video_player] Update to ExoPlayer 2.14.1 Jul 7, 2021
@stuartmorgan-g stuartmorgan-g mentioned this pull request Jul 7, 2021
Closed
11 tasks
@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Jul 7, 2021

Overriding the CLA; the commit here is cherry-picked directly from #3933 which was submitted to this project under the CLA.

@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Jul 7, 2021

(The reason this doesn't add tests is that the only thing this is intended to change is unbreaking the currently-broken presubmit tests by removing the dependency on Bintray, so our current tests are already catching the failure—"can't build"—that this PR is for.)

mvanbeusekom
mvanbeusekom approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit 1626b10 into flutter:master Jul 7, 2021
@stuartmorgan-g stuartmorgan-g deleted the video-player-exoplayer-2-14 branch July 7, 2021 15:30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 7, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2021
@engine-flutter-autoroll
1626b10 [video_player] Update to ExoPlayer 2.14.1 (flutter/plugins#4141)
668a7e6
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jul 7, 2021
@engine-flutter-autoroll
1626b10 [video_player] Update to ExoPlayer 2.14.1 (flutter/plugins#4141…
6ba25e8 
…) (#86022)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Jul 10, 2021
@stuartmorgan-g @amantoux
[video_player] Update to ExoPlayer 2.14.1 (flutter#4141)
0a50b5f 
Update the ExoPlayer dependency to the latest version, and remove the dependency on the deprecated Bintray server. This should resolve issues with building video_player due to 403s from bintray that have been breaking presubmits for all PRs.
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan-g @fotiDim
[video_player] Update to ExoPlayer 2.14.1 (flutter#4141)
fd88300 
Update the ExoPlayer dependency to the latest version, and remove the dependency on the deprecated Bintray server. This should resolve issues with building video_player due to 403s from bintray that have been breaking presubmits for all PRs.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: video_player platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuartmorgan-g @mvanbeusekom @kjeremy