[webview_flutter]Add the `loadRequest` method #4169

ydag · 2021-07-20T12:09:44Z

This PR adds the loadRequest method to unify all supported HTTP methods for loading a page with URL that are defined in WebViewLoadMethod. Also, it adds the WebViewRequest class to define parameters that can be used to load a page in WebView.

Related issues :

Fixes flutter/flutter#27730

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

.../webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java

packages/webview_flutter/webview_flutter/ios/Classes/FlutterWebView.h

packages/webview_flutter/webview_flutter/ios/Classes/FlutterWebView.m

# Conflicts: # packages/webview_flutter/webview_flutter/android/build.gradle # packages/webview_flutter/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java

# Conflicts: # packages/webview_flutter/webview_flutter/CHANGELOG.md # packages/webview_flutter/webview_flutter/pubspec.yaml

…to webview_flutter/add_post_url

google-cla · 2021-08-31T13:05:06Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

BeMacized · 2021-08-31T13:07:01Z

@googlebot I consent.

ydag · 2021-08-31T13:18:37Z

@googlebot I consent.

stuartmorgan-g · 2021-09-03T16:55:36Z

.../webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java

@@ -102,6 +110,12 @@ public void onProgressChanged(WebView view, int progress) {

    platformThreadHandler = new Handler(context.getMainLooper());

+    executorService = Executors.newFixedThreadPool(4);


Please add a comment explaining how the number 4 was derived; it seems very arbitrary.

stuartmorgan-g · 2021-09-03T16:56:27Z

.../webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java

@@ -282,6 +299,7 @@ public void onMethodCall(MethodCall methodCall, Result result) {
    }
  }

+  @Deprecated


Why are we deprecating a private method?

stuartmorgan-g · 2021-09-03T16:57:26Z

.../webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java

+    final WebViewRequest webViewRequest = buildWebViewRequest(methodCall);
+    if (webViewRequest == null) {
+      result.error("missing_args", "Missing arguments", null);
+    } else {


Nit: early return rather than else?

stuartmorgan-g · 2021-09-03T17:00:10Z

.../webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java

+                          null);
+                    } else {
+                      webView.loadDataWithBaseURL(
+                          webViewRequest.getUrl(), content, "text/html", "UTF-8", null);


Are we certain that the request URL is always correct? E.g., what happens here in the case of a server-side redirect to a different origin?

stuartmorgan-g · 2021-09-03T17:03:13Z

packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart

@@ -90,6 +91,7 @@ void main() {
    final Map<String, String> headers = <String, String>{
      'test_header': 'flutter_test_header'
    };
+    // ignore: deprecated_member_use


Why are there no new integration tests using the new API?

stuartmorgan-g · 2021-09-03T17:19:34Z

packages/webview_flutter/webview_flutter/lib/platform_interface.dart

@@ -187,6 +188,30 @@ abstract class WebViewPlatformController {
        "WebView loadUrl is not implemented on the current platform");
  }

+  /// Loads the specified URL.
+  ///
+  /// [WebViewRequest] must not be null.


Don't document things that are communicated by the type (and enforced by the compiler)

stuartmorgan-g · 2021-09-03T17:19:45Z

packages/webview_flutter/webview_flutter/lib/platform_interface.dart

+  /// If [WebViewRequest.body] is not null, it will be added as HTTP body
+  /// for the request.
+  ///
+  /// [WebViewRequest.uri] must not be null.


stuartmorgan-g · 2021-09-03T17:24:06Z

packages/webview_flutter/webview_flutter/lib/src/types/webview_request.dart

+        'headers': this.headers,
+        'body': this.body,
+      };
+}


Please add simple unit tests of this class, validating that toJson works.

stuartmorgan-g · 2021-09-03T17:25:25Z

packages/webview_flutter/webview_flutter/lib/webview_flutter.dart

+    required WebViewRequest request,
+  }) async {
+    assert(request != null);
+    _validateUri(request.uri);


Why not just inline this? It's a trivial method that's only used once.

stuartmorgan-g · 2021-09-03T17:26:06Z

packages/webview_flutter/webview_flutter/test/webview_flutter_test.dart

      await controller.loadUrl('https://google.com', headers: headers);

      expect(platform.lastUrlLoaded, 'https://google.com');
      expect(platform.lastRequestHeaders, headers);
    });
  });
+
  testWidgets('Set UserAgent', (WidgetTester tester) async {
    await tester.pumpWidget(const WebView(
      initialUrl: 'https://youtube.com',


Why are there no new tests for the new API?

stefanschaller · 2021-10-22T11:37:38Z

@ydag Any news about this PR? :) This feature would be really great

BeMacized · 2021-10-25T13:20:59Z

Closing this PR as it is currently being reworked, starting with #4450.

ydag added 15 commits July 20, 2021 13:19

Add postUrl method to platform interface

9eb8dd3

Add postUrl method to method channel

957ba7b

Add postUrl method to app-facing

b361ed7

Add postUrl call to OnMethodCall on Android

5ba03b8

Add postUrl method on Android

a99ce24

Add mockito dependency

730018c

Add a constructor for testing

aafea35

Add unit tests on Android

2c60a45

Add postUrl method call on iOS

d7d54f3

Add onPostUrl method

58121df

Add postRequest method

83557f8

Add postUrl method

8a6a524

Add new constructor for testing

b941672

Add mocking for testing on iOS

6233114

Add unit tests on iOS

1bc51fc

github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-android platform-ios labels Jul 20, 2021

ydag changed the title ~~Add postUrl method~~ [webview_flutter]Add postUrl method Jul 20, 2021

google-cla bot added the cla: yes label Jul 20, 2021

ydag added 3 commits July 20, 2021 14:13

Update version and CHANGELOG

3c0b775

Fix format

377a0f8

Merge branch 'master' into webview_flutter/add_post_url

68463e6

mvanbeusekom mentioned this pull request Jul 21, 2021

[webview_flutter] Refactored creation of Android WebView for testability. #4178

Merged

11 tasks

mvanbeusekom suggested changes Jul 22, 2021

View reviewed changes

stuartmorgan-g self-requested a review July 22, 2021 20:19

stuartmorgan-g reviewed Jul 22, 2021

View reviewed changes

packages/webview_flutter/webview_flutter/ios/Classes/FlutterWebView.m Outdated Show resolved Hide resolved

ydag added 3 commits July 23, 2021 14:41

Merge branch 'master' into webview_flutter/add_post_url

c405740

# Conflicts: # packages/webview_flutter/webview_flutter/android/build.gradle # packages/webview_flutter/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java

Add DisplayListenerProxy to constructor

6fa4255

Move the unit test to FlutterWebViewTest class

677f8b5

ydag and others added 11 commits August 20, 2021 13:36

Refactor test after changes on buildNSURLRequest

7862d30

Fix unit tests

b70b227

Revert changes for deprecated method

a37d770

Update version and CHANGELOG

433218c

Merge branch 'master' into webview_flutter/add_post_url

b702e1b

# Conflicts: # packages/webview_flutter/webview_flutter/CHANGELOG.md # packages/webview_flutter/webview_flutter/pubspec.yaml

Fix the import

64be755

Refactor headers to make it empty collections instead nullable

17a30f0

Add ignore for deprecated method

58fdf9e

Fix parameter

9c78996

Java: Added additional tests and small refactors

139b377

Merge remote-tracking branch 'origin/webview_flutter/add_post_url' in…

374bd47

…to webview_flutter/add_post_url

google-cla bot added cla: no and removed cla: yes labels Aug 31, 2021

google-cla bot added cla: yes and removed cla: no labels Aug 31, 2021

Fix tests

c095dc3

Add additional tests

817abe0

ydag changed the title ~~[webview_flutter]Update the loadUrl method~~ [webview_flutter]Add the loadRequest method Sep 1, 2021

Add license to test classes

27692b3

ydag requested a review from stuartmorgan-g September 3, 2021 08:34

stuartmorgan-g suggested changes Sep 3, 2021

View reviewed changes

BeMacized mentioned this pull request Oct 25, 2021

[webview_flutter] Add platform interface method loadRequest. #4450

Merged

11 tasks

BeMacized closed this Oct 25, 2021

This was referenced Nov 5, 2021

[webview_flutter] Implement loadRequest in Android package. #4479

Closed

[webview_flutter] Implement loadRequest in iOS package. #4480

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webview_flutter]Add the `loadRequest` method #4169

[webview_flutter]Add the `loadRequest` method #4169

ydag commented Jul 20, 2021 •

edited

Loading

google-cla bot commented Aug 31, 2021

BeMacized commented Aug 31, 2021

ydag commented Aug 31, 2021

stuartmorgan-g Sep 3, 2021

stuartmorgan-g Sep 3, 2021

stuartmorgan-g Sep 3, 2021

stuartmorgan-g Sep 3, 2021

stuartmorgan-g Sep 3, 2021

stuartmorgan-g Sep 3, 2021

stuartmorgan-g Sep 3, 2021

stuartmorgan-g Sep 3, 2021

stuartmorgan-g Sep 3, 2021

stuartmorgan-g Sep 3, 2021

stefanschaller commented Oct 22, 2021

BeMacized commented Oct 25, 2021

		@@ -102,6 +110,12 @@ public void onProgressChanged(WebView view, int progress) {

		platformThreadHandler = new Handler(context.getMainLooper());

		executorService = Executors.newFixedThreadPool(4);

[webview_flutter]Add the loadRequest method #4169

[webview_flutter]Add the loadRequest method #4169

Conversation

ydag commented Jul 20, 2021 • edited Loading

Pre-launch Checklist

google-cla bot commented Aug 31, 2021

BeMacized commented Aug 31, 2021

ydag commented Aug 31, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stefanschaller commented Oct 22, 2021

BeMacized commented Oct 25, 2021

[webview_flutter]Add the `loadRequest` method #4169

[webview_flutter]Add the `loadRequest` method #4169

ydag commented Jul 20, 2021 •

edited

Loading