This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Deprecate evaluateJavascript in favour of runJavaScript and runJavaScriptForResult. #4403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with new methods for running JavaScript
…sult` in iOS and Android packages.
…aScript` and `runJavaScriptForResult`
stuartmorgan-g
approved these changes
Nov 4, 2021
| /// On iOS depending on the value type the return value would be one of: | ||
| /// | ||
| /// - For primitive JavaScript types: the value string formatted (e.g JavaScript 100 returns '100'). | ||
| /// - For JavaScript arrays of supported types: a string formatted NSArray(e.g '(1,2,3), note that the string for NSArray is formatted and might contain newlines and extra spaces.'). |
There was a problem hiding this comment.
Please wrap to 80 characters.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2021
…unJavaScript and runJavaScriptForResult. (flutter/plugins#4403)
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Nov 4, 2021
* master: [webview_flutter] Deprecate evaluateJavascript in favour of runJavaScript and runJavaScriptForResult. (flutter#4403) [webview_flutter] Add interface methods to load local files and HTML strings. (flutter#4446) [ci] add pedantic dep to new in_app_purchase pkgs (flutter#4471) [ci] Remove unused dep from file_selector. (flutter#4468) [ci] update build_runner dep in android_intent and file_selector example (flutter#4467) [webview_flutter] Add platform interface method `loadRequest`. (flutter#4450) Remove -Werror from deprecated plugin Android builds (flutter#4466) [webview_flutter] Update webview packages for Android and iOS to implement `runJavascript` and `runJavascriptReturningResult`. (flutter#4402) [camera] Fix CamcorderProfile Usages (flutter#4423) [google_sign_in] Use a transparent image as a placeholder for the `GoogleUserCircleAvatar` (flutter#4391) [in_app_purchase]IAP/platform interface add cancel status (flutter#4093) [image_picker] doc:readme image picker misprints (flutter#4421) Support Hybrid Composition through the GoogleMaps Widget (flutter#4082) [path_provider] started supporting background platform channels (flutter#4443) [device_info] started using Background Platform Channels (flutter#4456) # Conflicts: # packages/webview_flutter/webview_flutter/CHANGELOG.md # packages/webview_flutter/webview_flutter/pubspec.yaml
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
…ript and runJavaScriptForResult. (flutter#4403)
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
…ript and runJavaScriptForResult. (flutter#4403)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new methods,
runJavaScriptandrunJavaScriptForResult, to supersedeevaluateJavascript.This is meant as a solution to the issue mentioned in flutter/flutter#66318, and was discussed offline with @mvanbeusekom and @stuartmorgan.
As this PR also depends on and includes the changes from #4401 and #4402, this PR will remain in draft state until those PRs are merged and published.Relevant issue:
Pre-launch Checklist
dart format.)[shared_preferences]///).