This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Bump compileSdkVersion to 31 #4432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| group 'io.flutter.plugins.camera' | |||
| version '1.0-SNAPSHOT' | |||
| def args = ["-Xlint:deprecation","-Xlint:unchecked","-Werror"] | |||
| def args = ["-Xlint:deprecation","-Xlint:unchecked"] | |||
There was a problem hiding this comment.
Would the removal of the -Werror flag be permanent? If not maybe add a comment explaining why it is temporary removed?
There was a problem hiding this comment.
this is temporary and can be reverted after #4423
| // Android SDK 20 is required by Google maps. | ||
| // Android SDK 19 is required by WebView. | ||
| newGradle.writeln('minSdkVersion 20'); | ||
| } else if (line.contains('compileSdkVersion')) { | ||
| // Android SDK 31 is required by Camera. |
There was a problem hiding this comment.
It seems very confusing to use exactly the same comment wording here for a very different kind of minimum requirement than is being described a couple of lines earlier.
There was a problem hiding this comment.
I'm not sure I fully get the concern. The app minSdkVersion/compileSdkVersion is dictated by the specific requirements of each plugin.
There was a problem hiding this comment.
I'm saying that just above, "Android SDK X is required" is referring to the runtime version requirement, and here "Android SDK X is required" is used to refer to the compile-time SDK.
Describing two completely different kinds of requirements with exactly the same text is very confusing.
| @@ -1,6 +1,6 @@ | |||
| group 'io.flutter.plugins.camera' | |||
| version '1.0-SNAPSHOT' | |||
| def args = ["-Xlint:deprecation","-Xlint:unchecked","-Werror"] | |||
There was a problem hiding this comment.
I assume the issue here is that the set of warnings will vary based on the build settings of the app depending on the plugin, so we don't want them to be errors?
There was a problem hiding this comment.
right. This is temporary as the fix is pending: #4423
|
PTAL. The plugins tree is red until this is merged due to flutter/flutter#91719 |
stuartmorgan-g
approved these changes
Oct 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 16, 2021
Hu1buerger
added a commit
to Hu1buerger/plugins
that referenced
this pull request
Oct 16, 2021
Checking wheter a integration test using shared_preferences as the storage backend should be able to check that the current instance is mocked. Not checking could result in overriding could override app runtime data or calling [setMockInitialValues] could lead to overriding data from the test. Updated pubspecVersion and changelog.md closes #1 fixing formating Merge to latest master Bump compileSdkVersion to 31 (flutter#4432)
camsim99
pushed a commit
to camsim99/plugins
that referenced
this pull request
Oct 18, 2021
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Oct 21, 2021
* master: [webview] Fix typos in the README (flutter#4249) [google_sign_in] add serverAuthCode to GoogleSignInAccount (flutter#4180) [ci] Update macOS Cirrus image to Xcode 13 (flutter#4429) [shared_preferences] Switch to new analysis options (flutter#4384) [flutter_plugin_android_lifecycle] remove placeholder dart file (flutter#4413) [camera] Run iOS methods on UI thread by default (flutter#4140) [ci] Always run all `format` steps (flutter#4427) [flutter_plugin_tools] Fix license-check on Windows (flutter#4425) [google_maps_flutter] Clean Java test, consolidate Marker example. (flutter#4400) [image_picker][android] suppress unchecked warning (flutter#4408) [ci] Replace Firebase Test Lab deprecated Pixel 4 device with Pixel 5 (flutter#4436) [image_picker_for_web] Added support for maxWidth, maxHeight and imageQuality (flutter#4389) Bump compileSdkVersion to 31 (flutter#4432) [camera] Update [CameraOrientationTests testOrientationNotifications] unit test to work on Xcode 13 (flutter#4426) Update integration_test README (flutter#3824) [webview_flutter] Adjust test URLs again (flutter#4407) [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179) [camera] Add filter for unsupported cameras on Android (flutter#4418)
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Oct 21, 2021
* master: [webview] Fix typos in the README (flutter#4249) [google_sign_in] add serverAuthCode to GoogleSignInAccount (flutter#4180) [ci] Update macOS Cirrus image to Xcode 13 (flutter#4429) [shared_preferences] Switch to new analysis options (flutter#4384) [flutter_plugin_android_lifecycle] remove placeholder dart file (flutter#4413) [camera] Run iOS methods on UI thread by default (flutter#4140) [ci] Always run all `format` steps (flutter#4427) [flutter_plugin_tools] Fix license-check on Windows (flutter#4425) [google_maps_flutter] Clean Java test, consolidate Marker example. (flutter#4400) [image_picker][android] suppress unchecked warning (flutter#4408) [ci] Replace Firebase Test Lab deprecated Pixel 4 device with Pixel 5 (flutter#4436) [image_picker_for_web] Added support for maxWidth, maxHeight and imageQuality (flutter#4389) Bump compileSdkVersion to 31 (flutter#4432) [camera] Update [CameraOrientationTests testOrientationNotifications] unit test to work on Xcode 13 (flutter#4426) Update integration_test README (flutter#3824) [webview_flutter] Adjust test URLs again (flutter#4407) [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179) [camera] Add filter for unsupported cameras on Android (flutter#4418) # Conflicts: # packages/webview_flutter/webview_flutter/CHANGELOG.md # packages/webview_flutter/webview_flutter/pubspec.yaml
yasargil
added a commit
to yasargil/plugins
that referenced
this pull request
Oct 25, 2021
* master: (364 commits) Use OpenJDK 11 in CI jobs (flutter#4419) [google_sign_in] remove the commented out code in tests (flutter#4442) [webview] Fix typos in the README (flutter#4249) [google_sign_in] add serverAuthCode to GoogleSignInAccount (flutter#4180) [ci] Update macOS Cirrus image to Xcode 13 (flutter#4429) [shared_preferences] Switch to new analysis options (flutter#4384) [flutter_plugin_android_lifecycle] remove placeholder dart file (flutter#4413) [camera] Run iOS methods on UI thread by default (flutter#4140) [ci] Always run all `format` steps (flutter#4427) [flutter_plugin_tools] Fix license-check on Windows (flutter#4425) [google_maps_flutter] Clean Java test, consolidate Marker example. (flutter#4400) [image_picker][android] suppress unchecked warning (flutter#4408) [ci] Replace Firebase Test Lab deprecated Pixel 4 device with Pixel 5 (flutter#4436) [image_picker_for_web] Added support for maxWidth, maxHeight and imageQuality (flutter#4389) Bump compileSdkVersion to 31 (flutter#4432) [camera] Update [CameraOrientationTests testOrientationNotifications] unit test to work on Xcode 13 (flutter#4426) Update integration_test README (flutter#3824) [webview_flutter] Adjust test URLs again (flutter#4407) [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179) [camera] Add filter for unsupported cameras on Android (flutter#4418) ... # Conflicts: # packages/google_maps_flutter/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the CI errors seen in #4418
I filed flutter/flutter#91771 to provide better error messages
seen the current error messages are very bad.