Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Remove "pluginClass: none" from pubspecs #4475

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Remove "pluginClass: none" from pubspecs #4475

merged 1 commit into from
Nov 10, 2021

Conversation

stuartmorgan-g
Copy link
Contributor

This workaround has not been needed since Flutter 1.20, and all plugins
now require at least Flutter 2.0, so it can be safely removed.

Part of flutter/flutter#57497

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g
Remove "pluginClass: none" from pubspecs
35465a9 
This workaround has not been needed since Flutter 1.20, and all plugins
now require at least Flutter 2.0, so it can be safely removed.

Part of flutter/flutter#57497
@google-cla google-cla bot added the cla: yes label Nov 4, 2021
@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Nov 4, 2021
@stuartmorgan-g stuartmorgan-g merged commit 020c855 into flutter:master Nov 10, 2021
@stuartmorgan-g stuartmorgan-g removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Nov 10, 2021
@stuartmorgan-g stuartmorgan-g deleted the remove-plugin-class-none branch November 10, 2021 19:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
@engine-flutter-autoroll
020c855 Remove "pluginClass: none" from pubspecs (flutter/plugins#4475)
02fb33c
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@stuartmorgan-g @amantoux
Remove "pluginClass: none" from pubspecs (flutter#4475)
7defe39 
This workaround has not been needed since Flutter 1.20, and all plugins
now require at least Flutter 2.0, so it can be safely removed.

Part of flutter/flutter#57497
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan-g @KyleFin
Remove "pluginClass: none" from pubspecs (flutter#4475)
c6eec58 
This workaround has not been needed since Flutter 1.20, and all plugins
now require at least Flutter 2.0, so it can be safely removed.

Part of flutter/flutter#57497
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blasten blasten blasten approved these changes

Assignees
No one assigned
Labels
cla: yes p: path_provider p: shared_preferences platform-linux platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @blasten