Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Change import of FLTCookieManager.h to relative import #4600

Merged
merged 3 commits into from
Dec 9, 2021
Merged

[webview_flutter] Change import of FLTCookieManager.h to relative import #4600

merged 3 commits into from
Dec 9, 2021

Conversation

BeMacized
Copy link
Contributor

This PR changes the import of FLTCookieManager.h in FlutterWebView.h to a relative import, to hopefully fix it picking up the header across modules.

@stuartmorgan I cannot reproduce the problem in the issue below, but I'm assuming this is the correct fix. Would you please be able to verify?

Related issue:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
    • Only an import change.
  • I added new tests to check the change I am making, or this PR is test-exempt.
    • Only an import change.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-ios labels Dec 9, 2021
@viplifes
Copy link

viplifes commented Dec 9, 2021

This is very critical for us. Please accept this merge.

@viplifes viplifes mentioned this pull request Dec 9, 2021
Closed
stuartmorgan-g
stuartmorgan-g approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@BeMacized BeMacized added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 9, 2021
@fluttergithubbot fluttergithubbot merged commit 33968c0 into flutter:master Dec 9, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 9, 2021
@engine-flutter-autoroll
33968c0 [webview_flutter] Change import of FLTCookieManager.h to rela…
5676bf4 
…tive import (flutter/plugins#4600)
@stuartmorgan-g stuartmorgan-g mentioned this pull request Dec 9, 2021
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 9, 2021
@engine-flutter-autoroll
33968c0 [webview_flutter] Change import of FLTCookieManager.h to rela…
03c0a90 
…tive import (flutter/plugins#4600)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@BeMacized @amantoux
[webview_flutter] Change import of FLTCookieManager.h to relative imp…
a5d949c 
…ort (flutter#4600)
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@BeMacized @KyleFin
[webview_flutter] Change import of FLTCookieManager.h to relative imp…
f83aaf1 
…ort (flutter#4600)
@waleedsyal123
Copy link

hello
Why is this issue taking too long to fix
i cannot run the app on ios due to this issue,
Please merge this pr. Thanks

@stuartmorgan-g
Copy link
Contributor

Why is this issue taking too long to fix

It was fixed within a day of being reported.

Please merge this pr.

It was merged over 7 months ago, as you can verify in the activity record above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees
No one assigned
Labels
needs tests p: webview_flutter Edits files for a webview_flutter plugin platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BeMacized @viplifes @waleedsyal123 @stuartmorgan-g @fluttergithubbot