Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Enable setAllowFileAccess on Android setting when loading files #4601

Merged
merged 6 commits into from
Dec 17, 2021
Merged

[webview_flutter] Enable setAllowFileAccess on Android setting when loading files #4601

merged 6 commits into from
Dec 17, 2021

Conversation

mvanbeusekom
Copy link
Contributor

@mvanbeusekom mvanbeusekom commented Dec 9, 2021 •
edited
Loading

This makes two changes:

  1. It adds the WebSettings.setAllowFileAccess() method to provide the option to enable/ disable this feature on Android;
  2. Ensures that the WebSettings.setAllowFileAccess() is called from the WebViewAndroidWidget.loadFile() method to ensure this option is enabled. Before Android API 30 this option is enabled by default, however on Android API 30 and up this behaviour is flipped and the option is now disabled by default which means the loadFile method doesn't work on these Android versions. This bug was not detected before because the webview_flutter_android example app is configured to target Android SDK 28 (details can be found here: https://developer.android.com/reference/android/webkit/WebSettings#setAllowFileAccess(boolean)).

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-android labels Dec 9, 2021
stuartmorgan-g
stuartmorgan-g approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the format issues fixed. I was wondering when closing that other PR last night how this worked 🙂 I missed the fact that the example was using an older version than the switch though.

I don't love the automatic permanent change of security setting when loading a file, but I didn't have a suggestion that doesn't feel more annoying for clients. We should do a follow-up to document that side effect in the app-facing method doc comment though.

stuartmorgan-g
stuartmorgan-g reviewed Dec 16, 2021
View reviewed changes
...android/android/src/main/java/io/flutter/plugins/webviewflutter/GeneratedAndroidWebView.java Outdated
@@ -1,7 +1,3 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be re-added for CI to pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry completely missed that. Just submitted an update.

@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 16, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 16, 2021
@stuartmorgan-g
Copy link
Contributor

Merging in master will help this pass Android tests

@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 17, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 17, 2021
@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 17, 2021
@fluttergithubbot fluttergithubbot merged commit d383fad into flutter:master Dec 17, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 20, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2021
@engine-flutter-autoroll
d383fad [webview_flutter] Enable setAllowFileAccess on Android settin…
9e7d5f2 
…g when loading files (flutter/plugins#4601)
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@mvanbeusekom @KyleFin
[webview_flutter] Enable setAllowFileAccess on Android setting when l…
393ec14 
…oading files (flutter#4601)
@mvanbeusekom mvanbeusekom deleted the webview_android_allow_file_access branch March 25, 2022 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees
No one assigned
Labels
p: webview_flutter Edits files for a webview_flutter plugin platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvanbeusekom @fluttergithubbot @stuartmorgan-g