Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] Switch to new analysis options #4604

Merged
merged 5 commits into from
Dec 13, 2021
Merged

[local_auth] Switch to new analysis options #4604

merged 5 commits into from
Dec 13, 2021

Conversation

stuartmorgan-g
Copy link
Contributor

Removes the legacy analysis options and fixes all violations. Most fixes were automated dart fix --apply changes.

Part of flutter/flutter#76229

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

cyanglaz
cyanglaz approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit 1a56bb2 into flutter:master Dec 13, 2021
@stuartmorgan-g stuartmorgan-g deleted the analysis-local-auth branch December 13, 2021 21:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 13, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2021
@engine-flutter-autoroll
1a56bb2 [local_auth] Switch to new analysis options (flutter/plugins#…
77ba02b 
…4604)
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan-g @KyleFin
[local_auth] Switch to new analysis options (flutter#4604)
0442e16 
Removes the legacy analysis options and fixes all violations. Most fixes were automated `dart fix --apply` changes.

Part of flutter/flutter#76229
@ashok-mechira-pwc

This comment has been minimized.

Sign in to view
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
p: local_auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan-g @ashok-mechira-pwc @cyanglaz