Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Fix a flaky test #4611

Merged
merged 3 commits into from
Dec 13, 2021
Merged

[video_player] Fix a flaky test #4611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff546d2
[video_player] Adjust a flaky test
stuartmorgan-g Dec 13, 2021
3e26db4
Fix the test
stuartmorgan-g Dec 13, 2021
3d16b08
Update CHANGELOG message
stuartmorgan-g Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/video_player/video_player/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Fixes integration tests.
* Updates Android compileSdkVersion to 31.
* Fixes a flaky integration test.

## 2.2.7

Expand Down
17 changes: 5 additions & 12 deletions packages/video_player/video_player/example/integration_test/video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,13 @@ void main() {
await networkController.setVolume(0);
final Completer<void> started = Completer();
final Completer<void> ended = Completer();
bool startedBuffering = false;
bool endedBuffering = false;
networkController.addListener(() {
if (networkController.value.isBuffering && !startedBuffering) {
startedBuffering = true;
if (!started.isCompleted && networkController.value.isBuffering) {
started.complete();
}
if (startedBuffering &&
if (started.isCompleted &&
!networkController.value.isBuffering &&
!endedBuffering) {
endedBuffering = true;
!ended.isCompleted) {
ended.complete();
}
});
Expand All @@ -72,11 +68,8 @@ void main() {
expect(networkController.value.position,
(Duration position) => position > const Duration(seconds: 0));

await started;
expect(startedBuffering, true);

await ended;
expect(endedBuffering, true);
await expectLater(started.future, completes);
await expectLater(ended.future, completes);
},
skip: !(kIsWeb || defaultTargetPlatform == TargetPlatform.android),
);
Expand Down