Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Prevent setting user agent string to default value on every rebuild #4618

Merged
merged 3 commits into from
Dec 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/webview_flutter/webview_flutter_android/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.8.1

* Fixes bug where the default user agent string was being set for every rebuild. See
https://github.com/flutter/flutter/issues/94847.

## 2.8.0

* Implements new cookie manager for setting cookies and providing initial cookies.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -418,11 +418,12 @@ class WebViewAndroidPlatformController extends WebViewPlatformController {
}

Future<void> _setUserAgent(WebSetting<String?> userAgent) {
if (userAgent.isPresent && userAgent.value != null) {
return webView.settings.setUserAgentString(userAgent.value!);
if (userAgent.isPresent) {
// If the string is empty, the system default value will be used.
return webView.settings.setUserAgentString(userAgent.value ?? '');
}

return webView.settings.setUserAgentString('');
return Future<void>.value();
}

Future<void> _setZoomEnabled(bool zoomEnabled) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: webview_flutter_android
description: A Flutter plugin that provides a WebView widget on Android.
repository: https://github.com/flutter/plugins/tree/master/packages/webview_flutter/webview_flutter_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22
version: 2.8.0
version: 2.8.1

environment:
sdk: ">=2.14.0 <3.0.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,32 @@ void main() {
});
});

testWidgets('no update to userAgentString when there is no change',
(WidgetTester tester) async {
await buildWidget(tester);

reset(mockWebSettings);

await testController.updateSettings(WebSettings(
userAgent: const WebSetting<String>.absent(),
));

verifyNever(mockWebSettings.setUserAgentString(any));
});

testWidgets('update null userAgentString with empty string',
(WidgetTester tester) async {
await buildWidget(tester);

reset(mockWebSettings);

await testController.updateSettings(WebSettings(
userAgent: const WebSetting<String?>.of(null),
));

verify(mockWebSettings.setUserAgentString(''));
});

testWidgets('currentUrl', (WidgetTester tester) async {
await buildWidget(tester);

Expand Down