[script]update the version check error output to include information … #4628
Conversation
…about how to trigger PR description upload
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -577,7 +577,9 @@ ${indentation}The first version listed in CHANGELOG.md is $fromChangeLog. | |||
| 'repository policy. If this is a false positive, please ' | |||
| 'add a line starting with\n' | |||
| '$_missingVersionChangeJustificationMarker\n' | |||
| 'to your PR description with an explanation of why it is exempt.'); | |||
| 'to your PR description with an explanation of why it is exempt.' | |||
| 'If editing PR description does not work, try rehashing your ' | |||
There was a problem hiding this comment.
What does "rehashing" mean? I can maybe guess, but it's not a standard git term that I've ever encountered, so it's not clear that this would clarify for most readers.
I don't think we wast to say "if editing does not work", since that could also happen if, say, someone typos the marker; we should more clearly state that triggerring a re-run won't work.
There was a problem hiding this comment.
We should also add this to the !hasChangelogChange message.
|
@hellohuanlin Are you still planning on finishing this PR? |
|
@stuartmorgan Yes. I plan to do it after camera work is done, as I may need to look into how to run this script. |
|
Close it for now. Will get back to it when I get a chance |
…about how to trigger PR description upload
I had this issue when I was trying to land #4608. I got this error:
So I updated the PR description and re-run the check, but still not working.
I suspected that it's because the PR description is not uploaded after edited for some reason. In order to verify this assumption, I rehashed the commit, which will most likely trigger the whole pipeline, and the error is gone.
For now, I figured that it may be helpful to include this as temp workaround in the error output.
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#95594
No version change:
This is only CI script.
Pre-launch Checklist
dart format.)[shared_preferences]*(I used [script] since it's not a plugin specific change)
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.