Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in_web] Update web package analysis options #4875

Merged
merged 4 commits into from
Feb 18, 2022
Merged

[google_sign_in_web] Update web package analysis options #4875

merged 4 commits into from
Feb 18, 2022

Conversation

stuartmorgan-g
Copy link
Contributor

Switches web package from legacy analysis options to
current analysis options, fixing all analysis issues it exposed.

Part of flutter/flutter#76229

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@ditman ditman changed the title [google_sign_in] Update web package analysis options [google_sign_in_web] Update web package analysis options Feb 18, 2022
ditman
ditman approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! That bogus await is a great find!

packages/google_sign_in/google_sign_in_web/lib/google_sign_in_web.dart
await auth2.getAuthInstance()?.currentUser?.get());
auth2.getAuthInstance()?.currentUser?.get());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, this is a very good find!

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Feb 18, 2022
@fluttergithubbot fluttergithubbot merged commit 1e7af5e into flutter:main Feb 18, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2022
@engine-flutter-autoroll
1e7af5e1d [google_sign_in_web] Update web package analysis options (f…
edc2f1c 
…lutter/plugins#4875)
@stuartmorgan-g stuartmorgan-g deleted the analysis-sign-in-web branch April 19, 2022 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
p: google_sign_in platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan-g @ditman @fluttergithubbot