This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider] Use a different Android channel name #4912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts the channel name reversion from 2.0.11, so that it is using a different channel name from the shared method channel (to avoid confusion if they diverge over time), as originally intended.
stuartmorgan-g
commented
Feb 23, 2022
| @@ -52,14 +52,6 @@ void main() { | |||
| log.clear(); | |||
| }); | |||
|
|
|||
| // TODO(stuartmorgan): Change this to a test that it uses a different name, | |||
There was a problem hiding this comment.
I removed it rather than changing it, since the reverse test didn't seem to actually be useful (and we don't have it anywhere else). I could add it if you think it's worthwhile though.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the channel name reversion from 2.0.11, so that it is using a
different channel name from the shared method channel (to avoid
confusion if they diverge over time), as originally intended.
Includes the update to 2.8 as a minimum Flutter version, which was
forgotten in the original change.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).