You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes image capture on Android 12 devices like the Pixel 6. After an image is captured, the device is stuck in STATE_CAPTURING because of the calls to stopRepeating() and abortCaptures() right after initiating the capture.
The best theory I can make is on devices like the Pixel 6 this causes the capture to never finish and the state machine is stuck in the capturing state forever because it aborted the capture before it finished. There must be a change in Android 12 that causes this to be an issue now.
One other note, these 2 calls were not present in the plugin prior to the big refactor last year I started that was later split into 9 different PRs. As part of the 9th PR, it seems @BeMacized added these calls in for some reason (did not see it documented unfortunately).
After removing these 2 calls, camera capture is working for the Pixel 6 and it still works for the Pixel 4 (Android 11).
I just tested #4572 on a pixel 6 and the image capture is still not working. While 4572 might fix another similar issue, it does not resolve the one I'm referring to here (and what flutter/flutter#92973 is referring to).
Can you please re-open the PR for review? I feel like we need to get @BeMacized's input as well to clarify why this was added in the first place, and why it didn't require explicit testing at that time.
I will also take a look at writing a test, using #4572 as inspiration.
Edit:
I had not checked out the correct branch. Indeed, #4572 fixes it, sorry to confuse with my reply.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes image capture on Android 12 devices like the Pixel 6. After an image is captured, the device is stuck in
STATE_CAPTURINGbecause of the calls tostopRepeating()andabortCaptures()right after initiating the capture.The best theory I can make is on devices like the Pixel 6 this causes the capture to never finish and the state machine is stuck in the capturing state forever because it aborted the capture before it finished. There must be a change in Android 12 that causes this to be an issue now.
One other note, these 2 calls were not present in the plugin prior to the big refactor last year I started that was later split into 9 different PRs. As part of the 9th PR, it seems @BeMacized added these calls in for some reason (did not see it documented unfortunately).
After removing these 2 calls, camera capture is working for the Pixel 6 and it still works for the Pixel 4 (Android 11).
Lines in question:
https://github.com/flutter/plugins/blame/main/packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java#L586-L587
Commit that broke it:
https://github.com/flutter/plugins/commit/0a86ac866b8b322a37d5fac36c7b15856a2b37e8#diff-97f0364e631a66ce678d82ff99[…]6c59511d7d848f8c33544eR556-R557
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).--> No new code to comment
--> No new behavior to test with a unit test
If you need help, consider asking for advice on the #hackers-new channel on Discord.