[ci] Update Chrome install script and version. #5098

ditman · 2022-03-22T00:54:52Z

This brings the version of Chrome that we use for integration web tests in line with the one used by flutter/flutter and flutter/engine.

No Issue (that I could find); at first I thought this would help with a test that I'm writing for an unrelated issue, but then I thought that the improvements to the script might be interesting (we might want to rollback the chromium build_id to what was there before?)

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This brings the version of Chrome that we use for integration web tests in line with the one used by flutter/flutter and flutter/engine.

flutter-dashboard · 2022-03-22T00:54:54Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan-g · 2022-03-23T15:01:29Z

script/install_chromium.sh

-mkdir "$TARGET_DIR"
-wget --no-verbose "https://www.googleapis.com/download/storage/v1/b/chromium-browser-snapshots/o/Linux_x64%2F${CHROMIUM_BUILD}%2Fchrome-linux.zip?alt=media" -O "$TARGET_DIR"/chromium.zip
-unzip "$TARGET_DIR"/chromium.zip -d "$TARGET_DIR"/
+mkdir $TARGET_DIR


Why did you remove the quotes here?

Because I had no idea what I was doing, but I've done some reading now :P

https://tldp.org/LDP/abs/html/quotingvar.html

script/install_chromium.sh

stuartmorgan-g · 2022-03-23T15:04:28Z

script/install_chromium.sh

+readonly CHROMIUM_BUILD=929514
+
+# The correct ChromeDriver is distributed alongside the chromium build above, as
+# `chromedriver_linux64.zip`, so no need to hardcode any extra info about it.


Do we know if this will be true in general going forward?

This has been true since February 2019:

https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Linux_x64/634372/

But I don't have any guarantees that this is going to continue to be true in the future (but it's very convenient as is!). Let me ask in YAQS, see if anybody responds.

Found where it started to happen (it's mentioned as a "temporary" workaround):

https://bugs.chromium.org/p/chromedriver/issues/detail?id=2656#c15

The issue is currently assigned to a Googler, I'll try to reach out to them when they're back in the office.

This has been true since February 2019

That sounds like the kind of "temporary" that's not likely to change a lot, so it seems fine to depend on. It's not like it's hard to go back to the old approach if it's changed without something better (and it sounds like it would probably remain this way until there's something better).

Yes, if this assumption changes, we'd also need to change the CIPD roller script in the engine repo (but that thing only runs seldomly, this script would break much earlier)

script/install_chromium.sh

stuartmorgan-g

LGTM

ditman · 2022-03-23T18:41:33Z

video player seems to be legitimately failing:

══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
The following PlatformException was thrown running a test:
PlatformException(VideoError, Failed to load video: The requested
URL was not found on this server., null, null)

But when the same URL is tested here it seems to work:

https://www.hlsplayer.net/#type=m3u8&src=https%3A%2F%2Fcph-p2p-msl.akamaized.net%2Fhls%2Flive%2F2000341%2Ftest%2Fmaster.m3u8

stuartmorgan-g · 2022-03-23T19:11:29Z

Transient server failure maybe? I really need to finish getting #4987 working to eliminate that URL.

stuartmorgan-g · 2022-03-23T19:18:03Z

I extracted the video_player part of that PR into #5103 since they are particular problematic (as demonstrated here).

ditman · 2022-03-23T19:35:43Z

Transient server failure maybe?

Looks like either a transient failure, or that we're getting throttled/rate limited. After a rerun, a different package failed (both tests use the same m3u8 URL, though!):

First:

The following packages had errors:
  video_player_avfoundation:

Then:

The following packages had errors:
  video_player/video_player:

I extracted the video_player part of that PR into #5103 since they are particular problematic (as demonstrated here).

Thanks for prioritizing that fix, I'll take a look!

stuartmorgan-g · 2022-03-23T20:18:53Z

That's landed, so hopefully merging main in will fix this test.

ditman · 2022-03-23T23:41:42Z

Looking much better in the current run (All ios test seem to have passed now). (Knock on wood.)

ditman · 2022-03-24T00:05:20Z

(No tests for this .sh file yet, I guess it could get migrated as a dart tool?)

stuartmorgan-g · 2022-03-24T02:31:17Z

(No tests for this .sh file yet, I guess it could get migrated as a dart tool?)

Potentially, but it's so simple that I tend to categorize it as "it is a test"; there's no way for it to fail without the tests that need it failing. (Unlike most of the repo tooling, where silently not failing when it should is a very real danger that's happened a bunch of times in the past.) We could potentially even teach the bot to ignore that specific file.

…gins#5098)

ditman · 2022-03-24T18:10:47Z

I tend to categorize it as "it is a test"; there's no way for it to fail without the tests that need it failing.

Yeah, that is a very good point!

[ci] Update Chrome install script and version.

46e822d

This brings the version of Chrome that we use for integration web tests in line with the one used by flutter/flutter and flutter/engine.

ditman requested a review from stuartmorgan-g March 22, 2022 00:54

flutter-dashboard bot added the needs tests label Mar 22, 2022

stuartmorgan-g reviewed Mar 23, 2022

View reviewed changes

Quote bash variables.

2bcc379

stuartmorgan-g approved these changes Mar 23, 2022

View reviewed changes

Merge branch 'flutter:main' into update-installed-chrome

d64c561

Merge branch 'flutter:main' into update-installed-chrome

37649bf

ditman added waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. last mile and removed needs tests labels Mar 24, 2022

fluttergithubbot merged commit 86b3621 into flutter:main Mar 24, 2022

ditman deleted the update-installed-chrome branch March 24, 2022 00:26

engine-flutter-autoroll mentioned this pull request Mar 24, 2022

Roll Plugins from 1bb37bd57d7c to 86b36210ed03 (2 revisions) flutter/flutter#100691

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2022

86b36210e [ci] Update Chrome install script and version. (flutter/plu…

7db811e

…gins#5098)

ditman removed waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. last mile labels Mar 24, 2022

mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023

[ci] Update Chrome install script and version. (flutter#5098)

2ac1ef8

[ci] Update Chrome install script and version. #5098

[ci] Update Chrome install script and version. #5098

Uh oh!

Conversation

ditman commented Mar 22, 2022

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Mar 22, 2022

Uh oh!

stuartmorgan-g Mar 23, 2022

Choose a reason for hiding this comment

Uh oh!

ditman Mar 23, 2022

Choose a reason for hiding this comment

Uh oh!

ditman Mar 23, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g Mar 23, 2022

Choose a reason for hiding this comment

Uh oh!

ditman Mar 23, 2022

Choose a reason for hiding this comment

Uh oh!

ditman Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 23, 2022

Choose a reason for hiding this comment

Uh oh!

ditman Mar 23, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

ditman commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g commented Mar 23, 2022

Uh oh!

stuartmorgan-g commented Mar 23, 2022

Uh oh!

ditman commented Mar 23, 2022

Uh oh!

stuartmorgan-g commented Mar 23, 2022

Uh oh!

ditman commented Mar 23, 2022

Uh oh!

ditman commented Mar 24, 2022

Uh oh!

stuartmorgan-g commented Mar 24, 2022

Uh oh!

ditman commented Mar 24, 2022

Uh oh!

Uh oh!

ditman Mar 23, 2022 •

edited

Loading

ditman commented Mar 23, 2022 •

edited

Loading